Community
Participate
Working Groups
Extracted from bug 133385: Okay, I had the chance to play with and test the new palette a little bit today (using the 0311 build). Here's my feedback: First, a few regressions and bugs I noticed: 1) Can't drag the palette while it's in flyout mode anymore 2) The palette flickers when it opens. It seems like it's laying out twice. First everything gets laid out and then the palette header is added at the top causing everything to move down. 3) Mouse-wheel scrolling doesn't work in drawers anymore. 4) The pin open action next to the drawer's name says "Pin Open" even when the drawer is already pinned open. Now that it is not a toggle button, it should say "unpin" or something like that. 5) The scrollbar seems to change color when I click on it to scroll. 6) The focus rectangle and selection rectangle are not consistent in the list layout mode. Click a palette entry in the list layout mode, and then hit the down arrow key and then the up arrow key again to see the problem. The focus rectangle is around the whole thing, whereas the selection rectangle does not stretch out all the way. I think it should stretch out all the way just like the focus rectangle. 7) There's no more feedback when resizing the palette via the keyboard. Is that what Eclipse does as well? See bug 133385 comment 39 and bug 133385 comment 42 for more discussion on this.
Pratik, I will contact you when I work on these bugs to figure out how to reproduce some of them. I have copied the previous comments to this bugzilla. > 1) Can't drag the palette while it's in flyout mode anymore > --> I never tested this. Hmmm, looks like the previous behavior was to support > dragging of the palette when hovering over the vertical title bar and resizing > of the palette when hovering over the blank area. Now, we no longer have the > title bar just the blank area. Any ideas how I should distinguish between > moving and resizing? Well, in the flyout mode, the user can still see the horizontal palette header when the palette comes up and he's still able to dock from there. So, maybe this is not that big a deal. He just can't dock it while it's in the collapsed flyout mode. If you want to support that, you can add a vertical palette label again. That also might not be bad because I think the current collapsed flyout palette is a little difficult to find. It camouflages into its environment a little too well. ;-) Maybe Cale or Andree might have some ideas here. > > 2) The palette flickers when it opens. It seems like it's laying out twice. > First everything gets laid out and then the palette header is added at the top > causing everything to move down. > --> I don't notice this with the GEF Logic Example. Were you using one of the > examples? I just notice that the palette's "hide palette" arrow on the right > of the header is delayed slightly in getting painted, but this behavior existed > before. Yup, I was using the GEF Logic example. If you can't reproduce, just ping me on Sametime, and I'll demo it for you. > > 3) Mouse-wheel scrolling doesn't work in drawers anymore. > --> Is there a trick to get this to work? I can't seem to use the mouse-wheel > to scroll with the old code either. I can scroll with my ThinkPad trackpoint in 3.3, but not in the new palette. I am surprised you can't. Again, I can demo this if you ping me. > 5) The scrollbar seems to change color when I click on it to scroll. > --> Do you mean it changes from orange to blue? It was supposed to. It's the > 'pressed down' effect I guess. Okay, maybe it needs to be rethought then? The scrollbar is blue by default. When I go over it, it becomes orange. I click on it, it becomes blue and scrolls. When scrolling is done, it becomes orange again (since my mouse is still over it). And then when I move my mouse to go select an entry it becomes blue again. > > 6) The focus rectangle and selection rectangle are not consistent in the list > layout mode. Click a palette entry in the list layout mode, and then hit the > down arrow key and then the up arrow key again to see the problem. The focus > rectangle is around the whole thing, whereas the selection rectangle does not > stretch out all the way. I think it should stretch out all the way just like > the focus rectangle. > --> Good point. I will make the focus rectangle match the selection rectangle. > The UI team did not want the selection rectangle to stretch out th whole way. Another reason that I think this looks more like a selection in a list rather than a push button. > > 7) There's no more feedback when resizing the palette via the keyboard. Is > that what Eclipse does as well? > --> What keystrokes do I use to resize the palette via the keyboard? Use the palette header's context menu.
Another minor thing: the tooltip for the pin (to keep the drawer open) doesn't have any padding. So the text ends up touching the tooltip's line border. A simple margin border (like the tooltips for the various creation tools use) will fix the problem.
Created attachment 95103 [details] proposed patch The attached patch makes the following changes: - The focus rectangle when using the keyboard on palette entries in list layout mode is now the same size as the blue/orange rectangles. - Text is now greyed out behind palette scroll buttons. - Fixed the feedback when resizing the palette via the keyboard. For some reason, the tracker does not draw correctly in stippled mode when the width is 3 pixels (which is the new width of the sash). I have removed the call to setStipple(true). It looks a bit different now, but I don't think it is a big deal. - Fixed title flickering issue. - Added a margin to the pin figure tooltip so it looks a bit nicer. Files changed: PaletteScrollBar, PinFigure, ToolEntryEditPart, FlyoutPaletteComposite. I tested mouse wheel scrolling of the drawers with the trackpoint (holding the middle key down) and it is working fine.
Committed to HEAD
