Bug 223664 - Compiler warning in org.eclipse.pde.ui.tests
Summary: Compiler warning in org.eclipse.pde.ui.tests
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.4 M6   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords: test
Depends on:
Blocks:
 
Reported: 2008-03-24 11:33 EDT by Dani Megert CLA
Modified: 2008-03-28 07:11 EDT (History)
1 user (show)

See Also:

Attachments
Patch (2.63 KB, patch)
2008-03-24 12:22 EDT, Curtis Windatt CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2008-03-24 11:33:07 EDT 
I20080323-2000.

There's a compile warning in the official Eclipse build.
Comment 1 Chris Aniszczyk CLA 2008-03-24 11:37:20 EDT 
Thanks Dani.
Comment 2 Curtis Windatt CLA 2008-03-24 12:22:17 EDT 
Created attachment 93288 [details]
Patch

Fixes the warning by running an assertEquals check on the unused variable.  The patch also turns off NLS warnings in the test plugin, which were just causing confusion.
Comment 3 Chris Aniszczyk CLA 2008-03-24 12:24:48 EDT 
Thanks Curtis.
Comment 4 Chris Aniszczyk CLA 2008-03-24 12:25:52 EDT 
done

> 20080324
Comment 5 Dani Megert CLA 2008-03-25 05:40:42 EDT 
Still present in I20080325-0100. Did PDE not contribute?
Comment 6 Chris Aniszczyk CLA 2008-03-25 09:38:52 EDT 
haven't tagged yet, will do for the afternoon build on 3/25
Comment 7 Dani Megert CLA 2008-03-28 07:11:45 EDT 
Verified in I20080327-2251.