Bug 223207 - [filetransfer][api] More generic handling of lastModified timestamp
Summary: [filetransfer][api] More generic handling of lastModified timestamp
Status: CLOSED FIXED
Alias: None
Product: ECF
Classification: RT
Component: ecf.filetransfer (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: ecf.core-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-03-19 11:37 EDT by Thomas Hallgren CLA
Modified: 2008-05-18 20:09 EDT (History)
2 users (show)

See Also:

Attachments
Patch to generilize handling of lastModified timestamp (7.42 KB, patch)
2008-03-19 11:37 EDT, Thomas Hallgren CLA 		no flags Details | Diff
Patch with both lastModified and with reparenting (9.21 KB, patch)
2008-03-20 03:14 EDT, Thomas Hallgren CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Hallgren CLA 2008-03-19 11:37:23 EDT 
Created attachment 92923 [details]
Patch to generilize handling of lastModified timestamp

The URLConnectionRetrieveFileTransfer and HttpClientRetrieveFileTransfer both obtain the 'lastModifiedTime' from the header fields for subsequent use when doing interrupted file transfer. This timestamp can be very useful when creating a local cache and it is not uncommon for remote protocols to support it.

The attached patch will make the lastModified timestamp generally available in the IIncomingFileTransfer interface. It adds the needed functionality for the EFS provider as well (+ EFS support for getRemoteFileName()). I did not find a way to do this with SCP although I'm not a wiz in that area so perhaps that's possible too.
Comment 1 Thomas Hallgren CLA 2008-03-20 03:14:58 EDT 
Created attachment 93000 [details]
Patch with both lastModified and with reparenting

This patch contains both the generalization of the lastModified timestamp and the reparenting of the IIncomingFileTransferReceiveStartEvent (as per discussion on ecf-dev list).
Comment 2 Scott Lewis CLA 2008-03-21 00:31:05 EDT 
Will apply this patch and commit tomorrow am pacific time.
Comment 3 Scott Lewis CLA 2008-03-21 15:20:08 EDT 
Applied patch, tested, updated IP log and committed to HEAD.  Thanks again, Thomas.  

Bug #223019
Comment 4 Scott Lewis CLA 2008-03-21 15:21:17 EDT 
(In reply to comment #3)
> Applied patch, tested, updated IP log and committed to HEAD.  Thanks again,
> Thomas.  
> 
> Bug #223019
> 

Meant to put 

Bug #223019 next.
Comment 5 Remy Suen CLA 2008-03-21 17:01:58 EDT 
We are missing @since tags. I also think we should tag things as @since 2.0 (or @since 2.0.0) and not @since 2.0.0 milestone 6.
Comment 6 Scott Lewis CLA 2008-03-21 20:47:32 EDT 
(In reply to comment #5)
> We are missing @since tags. I also think we should tag things as @since 2.0 (or
> @since 2.0.0) and not @since 2.0.0 milestone 6.
> 

Added @since for new method, and changed tags to @since 2.0.  Feel free to make such fixes directly where you observe them in the ECF codebase.
Comment 7 Scott Lewis CLA 2008-05-18 20:09:01 EDT 
closing and contributed keyword