Community
Participate
Working Groups
The Add/Edit/Delete buttons in the XML Catalog preference page are below the tree showing the existing entries, in contrast to almost every other presentation of information where the modifier buttons are on the right. This can be confusing as the area that users regularly look to for such buttons has none.
Gabriel, I think it would be nice if we could get this change in for M6. Otherwise it will have to wait for the next release :-(. Nitin, do you agree/disagree?
Created attachment 94387 [details] Patch This patch changes the layout so that buttons are shown on the right of the tree. It also ensures that the button to eliminate entries is labeled "Remove" instead of "Delete" for consistency.
Created attachment 94388 [details] ScreenShot of catalog with patch applied
Created attachment 94389 [details] Alternative patch This patch includes all of the previous while incorporating a border into the tree.
Created attachment 94391 [details] Screenshot of catalog with alternative patch applied
Thanks Gabriel, I've committed the second patch. One thing that could be improved is to make the tree initially wider. True, that will make the page wider but then I think that should be OK. I also don't much like the scroll bars on the details view. Not sure if they are needed or not... Anyway, that's for the future. Please also accept the bug since you are working on it already.
(In reply to comment #6) > Thanks Gabriel, I've committed the second patch. One thing that could be > improved is to make the tree initially wider. True, that will make the page > wider but then I think that should be OK. I also don't much like the scroll > bars on the details view. Not sure if they are needed or not... Anyway, that's > for the future. > Please also accept the bug since you are working on it already. The tree could be made initially wider, although one has to be careful as the length of the entries can be arbitrarily long, which could stretch the dialog box too much. Setting a maximum stretch implies you could potentially have clipped text (the reason for adjusting the tree size). The details associated to each entry can also be arbitrarily long, so scrollbars are needed.
(In reply to comment #7) > The tree could be made initially wider, although one has to be careful as the > length of the entries can be arbitrarily long, which could stretch the dialog > box too much. Setting a maximum stretch implies you could potentially have > clipped text (the reason for adjusting the tree size). > The details associated to each entry can also be arbitrarily long, so > scrollbars are needed. I think I meant making the initial size of the tree control a bit wider, not using the lenght of the longest entry key to dictate the width. And you're right, the horizontal scroll in the details is definitely needed. My issue was with the vertical one as the details view appears to alway show only 4 rows or so, but prehaps in some other languages the text will exceed the control height.
The patch was released for WTP 3.0 builds > v200804011700.
Verified with S-3.0M6-20080404114343
mass change to add 'contributed' keyword based on bugzilla query, please correct if that's not accurate (by marking patches as obsolete and removing the 'contributed' keyword.
Comment on attachment 94387 [details] Patch The alternative patch has been committed.
Closing.
Sorry, clicked on reopen by mistake.
