Bug 222458 - IType#getFullyQualifiedParameterizedName() is underspecified
Summary: IType#getFullyQualifiedParameterizedName() is underspecified
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M6   Edit
Assignee: Jerome Lanneluc CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-12 14:29 EDT by Markus Keller CLA
Modified: 2008-03-26 05:42 EDT (History)
1 user (show)

See Also:

Attachments
Proposed fix and regression tests (6.19 KB, patch)
2008-03-13 11:02 EDT, Jerome Lanneluc CLA 		no flags Details | Diff
Proposed fix and regression tests (6.19 KB, patch)
2008-03-13 11:04 EDT, Jerome Lanneluc CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2008-03-12 14:29:59 EDT 
HEAD

IType#getFullyQualifiedParameterizedName() does not define what version of "fully qualified name" is used. From looking at the 3 implementations, I think it is even inconsistent (BinaryType and SourceType use '.', but ResolvedBinaryType uses '$' as enclosingTypeSeparator).

I would change ResolvedBinaryType to use '.' as well and fix the Javadoc of IType#getFullyQualifiedParameterizedName(), also fixing the typo in the word "brakets" (should be "brackets").
Comment 1 Jerome Lanneluc CLA 2008-03-13 11:02:20 EDT 
Created attachment 92445 [details]
Proposed fix and regression tests
Comment 2 Jerome Lanneluc CLA 2008-03-13 11:04:09 EDT 
Created attachment 92447 [details]
Proposed fix and regression tests

Oops, forgot to fix the typo for "brackets"
Comment 3 Jerome Lanneluc CLA 2008-03-14 12:44:11 EDT 
Fix and tests released for 3.4M6
Comment 4 David Audel CLA 2008-03-26 05:42:34 EDT 
Verified for 3.4M6 using build I20080324-1300.