Bug 222421 - [p2] investigate launching story
Summary: [p2] investigate launching story
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P1 normal (vote)
Target Milestone: 3.4 M6   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-12 11:01 EDT by Chris Aniszczyk CLA
Modified: 2008-03-19 19:09 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Aniszczyk CLA 2008-03-12 11:01:12 EDT
> 20080311

Case #1 (bad behavior)

1) create an rcp application using the mail template
2) launch using the overview "Launch an Eclipse Application" link

The config.ini that is written out contains just simple configurator in the osgi.bundles property

In this case, I'd expect us to just write out all things selected in the launch configuration to osgi.bundles instead of simpleconfigurator

Case #2 (good behavior)

1) create an rcp application using the mail template
2) launch using the overview "Launch an Eclipse Application" link
3) modify launch configurator to explicitly include org.eclipse.equinox.simpleconfigurator

The config.ini that is written out contains just simple configurator in the osgi.bundles property. This is correct behavior.
Comment 1 Chris Aniszczyk CLA 2008-03-12 11:03:33 EDT
Curtis, you should see the same behavior in regards to update.configurator

If we include it, that should only get written out (with osgi I think). If not, everything gets written out to osgi.bundles

We should also example what happens if update.configurator AND simple.configurator are included... have to catch these esoteric cases.
Comment 2 Chris Aniszczyk CLA 2008-03-13 15:45:24 EDT
This is the way it should work:

1) if no configurator listed, osgi.bundles list every bundle to run
2) if update.configurator only, use it
3) if simple.configurator only, use it
4) if both configurators selected, use simple configurator and set
org.eclipse.update.reconcile=false in config.ini
Comment 3 Chris Aniszczyk CLA 2008-03-19 17:11:09 EDT
I think we're good now with my latest updates.

> 20080319
Comment 4 Chris Aniszczyk CLA 2008-03-19 17:11:40 EDT
done.
Comment 5 Curtis Windatt CLA 2008-03-19 19:09:09 EDT
Boourns, I had a fix for this as well.  I was too slow though.  I merged my changes and will put a patch up on Bug 221859.