222403 – [code assist] no proposals after uninstalling Mylyn

Bug 222403 - [code assist] no proposals after uninstalling Mylyn

Summary: [code assist] no proposals after uninstalling Mylyn

Status:	VERIFIED FIXED

Alias:	None

Product:	JDT
Classification:	Eclipse Project
Component:	Text (show other bugs)
Version:	3.4
Hardware:	PC Mac OS X - Carbon (unsup.)

Importance:	P3 normal (vote)
Target Milestone:	3.4 RC2
Assignee:	JDT-Text-Inbox
QA Contact:

URL:
Whiteboard:
Keywords:

Duplicates (3):	209213 230363 234510 (view as bug list)
Depends on:
Blocks:

Reported:	2008-03-12 09:30 EDT by Adelino Rodrigues
Modified:	2008-05-29 03:07 EDT (History)
CC List:	6 users (show)

See Also:

Flags:	daniel_megert: review+ martinae: review+ benno.baumgartner: review+

Attachments
Screenshot showing auto complete not working (29.00 KB, image/png) 2008-03-12 09:35 EDT, Adelino Rodrigues	no flags	Details
Full configuration details (159.81 KB, text/plain) 2008-03-13 03:56 EDT, Adelino Rodrigues	no flags	Details
patch (7.09 KB, patch) 2008-05-08 11:11 EDT, Martin Aeschlimann	no flags	Details \| Diff
improved patch (7.60 KB, patch) 2008-05-08 11:46 EDT, Martin Aeschlimann	no flags	Details \| Diff
Fix for pre 3.4 workspace (4.05 KB, patch) 2008-05-22 05:47 EDT, Dani Megert	no flags	Details \| Diff
Better Fix (5.75 KB, patch) 2008-05-22 10:55 EDT, Dani Megert	no flags	Details \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Adelino Rodrigues

2008-03-12 09:30:46 EDT

When editing java files, the autocomplete never works on Mac OS Leopard. It always displays the message as in the attached picture.

Comment 1 Adelino Rodrigues

2008-03-12 09:35:01 EDT

Created attachment 92297 [details]
Screenshot showing auto complete not working

Comment 2 Dani Megert

2008-03-12 10:46:10 EDT

Which build? Did you eventually install Mylyn or Mylar and then moved to a new install of the SDK without adding Mylyn again?

Comment 3 Adelino Rodrigues

2008-03-13 03:56:21 EDT

Created attachment 92401 [details]
Full configuration details

Comment 4 Dani Megert

2008-03-13 04:04:18 EDT

This is a known Mylyn bug: they tweak the preferences and once this workspace is moved on to a new build without Mylyn you can end up with this.

1. go to the following preference page:
    Java > Editor > Content Assist > Advanced
2. click 'Restore Defaults'
3. click 'OK'

This should fix your problem.

Comment 5 Dani Megert

2008-03-13 04:08:17 EDT

See bug 209213 for details.

*** This bug has been marked as a duplicate of bug 209213 ***

Comment 6 Adelino Rodrigues

2008-03-13 04:29:36 EDT

This fixes the issue indeed. Thanks.

Comment 7 Dani Megert

2008-05-06 06:56:30 EDT

*** Bug 230363 has been marked as a duplicate of this bug. ***

Comment 8 Martin Aeschlimann

2008-05-08 11:06:54 EDT

reopening.

Comment 9 Martin Aeschlimann

2008-05-08 11:11:22 EDT

Created attachment 99306 [details]
patch

Suggested fix for the Java editor. Code assist warns when it detects that code assist proposal computers got removed since the last start.

Comment 10 Dani Megert

2008-05-08 11:13:15 EDT

*** Bug 209213 has been marked as a duplicate of this bug. ***

Comment 11 Martin Aeschlimann

2008-05-08 11:46:43 EDT

Created attachment 99313 [details]
improved patch

Comment 12 Dani Megert

2008-05-09 06:12:44 EDT

I've committed a slightly modified version of the patch.
Martin, can you please verify that it works.
Thanks!

Comment 13 Benno Baumgartner

2008-05-21 10:31:03 EDT

I can not verify that it works: Install mylyn in 3.3.2, then start 3.4RC1 on same workspace without mylyn installed and you get no proposals (except SWT template proposals).

Comment 14 Dani Megert

2008-05-21 10:53:51 EDT

Right, the new fix only works for workspace >= 3.4 RC1. Will add some more guards.

Comment 15 Dani Megert

2008-05-22 05:47:01 EDT

Created attachment 101457 [details]
Fix for pre 3.4 workspace

Comment 16 Dani Megert

2008-05-22 05:51:26 EDT

Benno, besides reviewing can you also test the following two scenarios:

Scenario 1
1. start fresh workspace with 3.3 + Mylyn
2. do some code assist (no dialog should appear)
3. exit
4. start that workspace 3.4_with_my_fix
5. code assist
==> dialog should appear

Scenario 2
1. start fresh workspace with 3.4_with_my_fix + Mylyn
2. do some code assist (no dialog should appear)
3. exit
4. start that workspace with 3.4_with_my_fix
5. code assist
==> dialog should appear

Comment 17 Benno Baumgartner

2008-05-22 10:35:33 EDT

(In reply to comment #16)
> Benno, besides reviewing can you also test the following two scenarios:
> 
> Scenario 1
> 1. start fresh workspace with 3.3 + Mylyn
> 2. do some code assist (no dialog should appear)
> 3. exit
> 4. start that workspace 3.4_with_my_fix
> 5. code assist
> ==> dialog should appear

Green

> Scenario 2
> 1. start fresh workspace with 3.4_with_my_fix + Mylyn
> 2. do some code assist (no dialog should appear)
> 3. exit
> 4. start that workspace with 3.4_with_my_fix
> 5. code assist
> ==> dialog should appear

Green

+1 for RC2

Comment 18 Dani Megert

2008-05-22 10:55:07 EDT

Created attachment 101521 [details]
Better Fix

Better patch:
- rearrange the if conditions for Martin ;-)
- leave the reset call as is
- update dialog message

Comment 19 Martin Aeschlimann

2008-05-22 11:05:59 EDT

patch is good.

Comment 20 Benno Baumgartner

2008-05-22 11:23:11 EDT

Also +1

Comment 21 Dani Megert

2008-05-22 11:26:40 EDT

Fixed in HEAD.
Available in build I20080522-1800.

Comment 22 Dani Megert

2008-05-23 11:40:54 EDT

Benno, may I ask you to verify that bug? Thanks.

Comment 23 Benno Baumgartner

2008-05-26 04:41:26 EDT

verified both scenarios from comment 16 in I20080523-0100

Comment 24 Dani Megert

2008-05-29 03:07:40 EDT

*** Bug 234510 has been marked as a duplicate of this bug. ***