Bug 222363 - [tcf] Initial implementation of value-add
Summary: [tcf] Initial implementation of value-add
Status: RESOLVED FIXED
Alias: None
Product: TCF
Classification: Tools
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P2 enhancement (vote)
Target Milestone: 0.1   Edit
Assignee: Felix Burton CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-03-12 05:00 EDT by Felix Burton CLA
Modified: 2013-06-05 08:05 EDT (History)
3 users (show)

See Also:

Attachments
Initial value-add framework (54.60 KB, patch)
2008-03-12 05:00 EDT, Felix Burton CLA 		mober.at+eclipse: iplog+
Details | Diff
Fix to close channel when EOM is received from remote peer (2.34 KB, patch)
2008-03-13 06:42 EDT, Felix Burton CLA 		mober.at+eclipse: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Burton CLA 2008-03-12 05:00:01 EDT 
Created attachment 92276 [details]
Initial value-add framework

The attached patch is an initial implementation of value-add (proxy) framework.  In order to implement this, some APIs were simplifed and several bug fixes around disconnect were fixed.
Comment 1 Martin Oberhuber CLA 2008-03-12 06:13:53 EDT 
Eugene can you please review and apply this patch. I'd love to have it before EclipseCon. It adds the "Proxy" service as well as a "main_va.c" program for "valueadd.exe".

Patch size is 638 lines and looks good to me from IP point of view.

What I'd love to see as next step is split the "agent" directory into
  (1) library folder common to all TCF agents/valueadds/clients
      --> built into "tcf.a" library for main programs to link against
      (1a) lib/framework for the framework code e.g. JSON
      (1b) lib/services for the various service code
  (2) separate folders for the main programs

Having such a structure would tremendously help potential adopters understanding the structure of the agent and how to re-use parts of it.
Comment 2 Eugene Tarassov CLA 2008-03-12 14:56:50 EDT 
I commited the patch after makeing some changes:

1. Fixed udp_send_peer_sever() in discovery_udp.c - it could send malformed UDP packets because of misplaced "pos = 0" statement.

2. Removed invalid assert in org.eclipse.tm.internal.tcf.debug.ui.launch.TCFMainTab

3. A few cosmetic changes
Comment 3 Martin Oberhuber CLA 2008-03-13 05:12:09 EDT 
Thanks Eugene. Please don't forget logging the contribution in the "tm-log.csv" file and setting the "contributed" keyword here on bugzilla.
Comment 4 Felix Burton CLA 2008-03-13 06:42:18 EDT 
Created attachment 92417 [details]
Fix to close channel when EOM is received from remote peer
Comment 5 Eugene Tarassov CLA 2008-03-24 17:44:34 EDT 
Commited to SVN
Comment 6 Martin Oberhuber CLA 2008-10-07 05:39:31 EDT 
Comment on attachment 92276 [details]
Initial value-add framework

Felix, I just noticed that you made these contributions before you actually became a committer, so we need your explicit statement that you license these under EPL+EDL. Given that your contributions are for the agent, they must be dual-licensed. To make it official, can you please add a comment here on bugzilla based on the template you find here:

http://www.eclipse.org/dsdp/tm/development/committer_howto.php#external_contrib
Comment 7 Doug Schaefer CLA 2011-05-17 10:50:19 EDT 
Moving bugs to new home for IP log.
Comment 8 Martin Oberhuber CLA 2013-06-05 06:35:57 EDT 
Bulk update: Marking all bugs from the TM era (before June 2011) target 0.3