Bug 222238 - Problems with migrated OSGi launch configs
Summary: Problems with migrated OSGi launch configs
Status: RESOLVED WORKSFORME
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday
Depends on:
Blocks:
 
Reported: 2008-03-11 10:42 EDT by Michael Schneider CLA
Modified: 2009-04-28 11:46 EDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Schneider CLA 2008-03-11 10:42:44 EDT
Build ID: I20080207-1530

Our OSGi Framework launch configs created with Eclipse 3.3.1 so not work after migrating to 3.4M5 anymore.

It seems that 3.3.1 added
eclipse.ignoreApp=true
osgi.noShutdown=true
to the config.ini automatically, while 3.4M5 does not

when creating new launch configs with 3.4M5, these properties are added as VM arguments. However, they are not added when migrating an old config.
Comment 1 Chris Aniszczyk CLA 2008-03-11 11:00:57 EDT
That's puzzling given the code in OSGiMigrationDelegate.migrate(...) should exactly do that...
Comment 2 Benjamin Cabé CLA 2008-03-11 13:17:48 EDT
Michael, can you please attach your .launch configuration files?
Aren't they prior to 3.3? Because, AFAIK, nothing was changed between 3.3.X and 3.4. I've created OSGi launch configuration with both a 3.3.1.1 and a 3.4.HEAD and both files had an entry:
<stringAttribute key="org.eclipse.jdt.launching.VM_ARGUMENTS" value="-Declipse.ignoreApp=true -Dosgi.noShutdown=true"/>

I believe OSGiMigrationDelegate.migrate(...) responsibility is to migrate launch configuration *older than* 3.3.x to 3.3.x+
Comment 3 Michael Schneider CLA 2008-03-12 06:26:33 EDT
<?xml version="1.0" encoding="UTF-8"?>
<launchConfiguration type="org.eclipse.pde.ui.EquinoxLauncher">
<booleanAttribute key="automaticAdd" value="false"/>
<booleanAttribute key="automaticValidate" value="true"/>
<stringAttribute key="bootstrap" value=""/>
<stringAttribute key="checked" value="[NONE]"/>
<booleanAttribute key="clearConfig" value="true"/>
<stringAttribute key="configLocation" value="${workspace_loc}/.metadata/.plugins/org.eclipse.pde.core/Embedded Jetty 5.1.10 with Bridge WorkItem"/>
<booleanAttribute key="default_auto_start" value="true"/>
<intAttribute key="default_start_level" value="4"/>
<booleanAttribute key="includeOptional" value="false"/>
<booleanAttribute key="org.eclipse.debug.core.appendEnvironmentVariables" value="true"/>
<stringAttribute key="org.eclipse.jdt.launching.PROGRAM_ARGUMENTS" value="-console"/>
<stringAttribute key="org.eclipse.jdt.launching.SOURCE_PATH_PROVIDER" value="org.eclipse.pde.ui.workbenchClasspathProvider"/>
<stringAttribute key="org.eclipse.jdt.launching.VM_ARGUMENTS" value="-Dorg.mortbay.log.LogFactory.noDiscovery=true -Dorg.eclipse.equinox.servlet.bridge.enabled=true -Dcom.ibm.team.repository.db.jdbc.location=&quot;${workspace_loc}/../workitem-apt-runtime/teamRepositoryDB&quot; -Dderby.stream.error.file=&quot;${workspace_loc}/../junit-workspace/derby.log&quot;"/>
<stringAttribute key="target_bundles" value="com.ibm.icu@default:default,javax.servlet@default:default,org.eclipse.core.commands@default:default,org.eclipse.core.contenttype@2:default,org.eclipse.core.jobs@1:default,org.eclipse.core.runtime@2:default,org.eclipse.emf.common@3:default,org.eclipse.emf.commonj.sdo@3:default,org.eclipse.emf.ecore@3:default,org.eclipse.emf.ecore.change@3:default,org.eclipse.emf.ecore.sdo@3:default,org.eclipse.emf.ecore.xmi@3:default,org.eclipse.emf.mapping.ecore2xml@3:default,org.eclipse.equinox.app@default:default,org.eclipse.equinox.common@1:default,org.eclipse.equinox.http.registry@default:default,org.eclipse.equinox.http.servlet@default:default,org.eclipse.equinox.preferences@1:default,org.eclipse.equinox.registry@2:default,org.eclipse.jdt.junit.runtime@default:default,org.eclipse.osgi@:,org.eclipse.osgi.services@1:default,org.eclipse.pde.junit.runtime@default:default,org.eclipse.text@default:default,org.junit@default:default,org.mortbay.jetty@default:default"/>
<booleanAttribute key="tracing" value="false"/>
<booleanAttribute key="useDefaultConfigArea" value="true"/>
<stringAttribute key="workspace_bundles" value="com.ibm.team.apt.common@default:default,com.ibm.team.apt.service@default:default,com.ibm.team.apt.web@default:default,com.ibm.team.filesystem.common@default:default,com.ibm.team.filesystem.service@default:default,com.ibm.team.foundation.common@default:default,com.ibm.team.foundation.service@default:default,com.ibm.team.fulltext.common@default:default,com.ibm.team.fulltext.service@default:default,com.ibm.team.gateway.service@default:default,com.ibm.team.process.common@default:default,com.ibm.team.process.service@default:default,com.ibm.team.process.service.migration@default:default,com.ibm.team.process.web@default:default,com.ibm.team.repository.common@default:default,com.ibm.team.repository.common.json@default:default,com.ibm.team.repository.common.remoteaccess@default:default,com.ibm.team.repository.common.serialize@default:default,com.ibm.team.repository.common.serialize.tests@default:default,com.ibm.team.repository.common.tests@default:default,com.ibm.team.repository.common.transport@default:default,com.ibm.team.repository.jdbcdriver.db2@default:default,com.ibm.team.repository.jdbcdriver.derby@default:default,com.ibm.team.repository.jndi@default:default,com.ibm.team.repository.provision@default:default,com.ibm.team.repository.service@default:default,com.ibm.team.repository.service.tests@default:default,com.ibm.team.repository.servlet@default:default,com.ibm.team.repository.tests.common@default:default,com.ibm.team.repository.tests.common.fragment@default:default,com.ibm.team.repository.tests.service@default:default,com.ibm.team.repository.web@default:default,com.ibm.team.scm.admin.common@default:default,com.ibm.team.scm.common@default:default,com.ibm.team.scm.service@default:default,com.ibm.team.server.embedded.jetty@default:default,com.ibm.team.server.embedded.jetty.auth@default:default,com.ibm.team.server.embedded.webapp.bridge@default:default,com.ibm.team.workitem.common@default:default,com.ibm.team.workitem.service@default:default,com.ibm.team.workitem.web@default:default,javax.mail@default:default,net.jazz.ajax@default:default,org.apache.commons.codec@default:default,org.apache.commons.httpclient@default:default,org.apache.commons.logging@default:default,org.apache.derby.core@default:default,org.apache.log4j@default:default,org.apache.lucene2@default:default,org.apache.naming@default:default,org.dojotoolkit@default:default,org.eclipse.test.performance@default:default,org.mozilla.rhino@default:default"/>
</launchConfiguration>


Comment 4 Benjamin Cabé CLA 2008-03-12 06:31:17 EDT
Okay thanks!
So this is a launch configuration created with an Eclipse version older than 3.3, right?
Comment 5 Michael Schneider CLA 2008-03-12 06:37:24 EDT
Cant really say, as the configurations are shared. I dont know who created it initially and which version of eclipse he was using. I would guess it was one of the 3.3 milestone builds
Comment 6 Benjamin Cabé CLA 2008-03-12 06:58:41 EDT
OK. I'll investigate using the launch configuration you attached
Comment 7 Darin Wright CLA 2009-04-28 11:45:03 EDT
This is an old bug... if new configurations are working, suggest to close.
Comment 8 Chris Aniszczyk CLA 2009-04-28 11:46:03 EDT
agreed