Bug 222152 - [message editor]undo does not work on properties page
Summary: [message editor]undo does not work on properties page
Status: ASSIGNED
Alias: None
Product: Babel
Classification: Technology
Component: Plugins (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Alexej Strelzow CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-10 21:31 EDT by Kit Lo CLA
Modified: 2022-09-24 05:14 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kit Lo CLA 2008-03-10 21:31:13 EDT
undo does not work on properties page

testcase:
- open a properties file with the message editor
- select a key in the key tree
- modify the key value in the editor area
- notice than an '*' is addded to the editor label indicating the file is changed
- press ctrl+z to undo the typing
- the '*' is removed from the editor label
- however, the modification to the key value is still in the edit area

Another note, undo/redo works fine on the default page of the message editor
Comment 1 Alexej Strelzow CLA 2012-11-10 08:56:29 EST
This is very hard to do, because its implementation is different from org.eclipse.ui.editors.text.TextEditor (which is the default-page).

In our case, undo impl. from class Control is used:

case OS.WM_UNDO: result = WM_UNDO (wParam, lParam); break;

This invokes the class Text, which returns: wmClipboard (OS.WM_UNDO, wParam, lParam);

To make this functionality more like the one in TextEditor, I implemented the an own listener -> UndoKeyListener.

This listener has almost the same behaviour. Maybe I'll find a better impl. soon...
Comment 2 Eclipse Genie CLA 2014-11-01 06:33:39 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 3 Eclipse Genie CLA 2016-10-22 03:03:22 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 4 Eclipse Genie CLA 2018-10-13 13:37:35 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 5 Eclipse Genie CLA 2020-10-03 16:03:24 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 6 Eclipse Genie CLA 2022-09-24 05:14:07 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.