Bug 222135 - [ui] when sizing discovers artifacts missing, report to the user before trying to install
Summary: [ui] when sizing discovers artifacts missing, report to the user before tryin...
Status: RESOLVED WONTFIX
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: P2 Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted, usability
Depends on: 212811
Blocks:
  Show dependency tree
 
Reported: 2008-03-10 18:41 EDT by Jeff McAffer CLA
Modified: 2020-02-21 01:37 EST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff McAffer CLA 2008-03-10 18:41:17 EDT
so I was whipping along having a great time.  Tunes on, glass of wine, good progress and then it happened.  I could no longer install using the admin UI.  Everything had been working smoothly.  I changed something.  But what?  Check check, try try, look look, cry cry.  another glass of wine?

the error against which I was banging my head was a dandy resolution but nothing to install.  0 install size.  That can't be good.  Hunt some more.

Alas, I am an idiot.  I had not added the artifact repo.

Moral of the story:  more wine is likely better

Bug of the story:  we need some better feedback when an install operation says that it has to install some stuff but the required artifacts are not available.


As it is if you hit the Finish button you get a dialog syaing that various things could not be found.  That's likely the result of actually trying to get the things.  However, since the UI said there was nothing to download and I knew I had nothing, I didn't even bother to hit Finish.  Ok, I'm a moron but I'm likely not unique.

if some ofthe things were availabel I suspect that hitting Finish would have gone and started downloading the things that were available.  If some of the required stuff was comeing from another repo that had not been added, then the install is not going to complete.  Would be good to tell the user that up front so they dont' spend time downloading stuff that will not work.
Comment 1 Pascal Rapicault CLA 2008-03-10 20:33:27 EDT
Marking as a dependent and keeping open to discuss the UI improvments
Comment 2 Susan McCourt CLA 2008-08-20 13:14:16 EDT
renaming so it's clear this is not just an error message issue.
Comment 3 John Arthorne CLA 2009-04-13 16:12:05 EDT
Given the set of bugs left for 3.5 I don't think this will happen without a contribution. In the end this would be a nice usability improvement, but since sizing happens in the background and often doesn't finish before the user hits Finish, it won't always help.
Comment 4 Matthew Piggott CLA 2009-04-14 16:11:36 EDT
Just a note that the Sizing phase does return a status code when it is unable to find artifacts or when the repository doesn't provide size information.
Comment 5 Susan McCourt CLA 2009-04-14 17:51:39 EDT
Rereading the original comment:
- nothing to install and 0 install size.  Not clear if there were items listed in the install details page and a 0 size, or no items in the list at all.  We had bugs in 3.4 where some resolutions would advance in the wizard and there was nothing listed to install.  That doesn't happen anymore.  
- if there was stuff listed and size was 0, then a size of 0 was computed.  Given Matt's work in bug 212811, we now say size is "Unknown" if an artifact was found missing.  Before we reported the partial size. 

In 3.5, we are better off than when originally reported, because you would have never gotten to the details page if there was truly nothing to be installed, and if there was something to install ,you'd see the list (and drilldown) of everything to be installed, and either a size or "Unknown."  So the problem of "I never pushed finish because it didn't look like there was anything to install" shouldn't happen anymore.

The question remaining in this bug is whether it's valuable to report a missing artifact when discovered during sizing.  The wizard reports errors that are detected prior to resolution (such as locked IU's) or during resolution (things the planner reported).  Normally, those errors found later (missing artifact, signature verification issue, etc.) are reported as they are found.

It's not clear what a good workflow would be.  We wouldn't want to randomly move the user back to the error page when the sizing finished.  We could report something underneath the sizing info  "some stuff is missing, the install is probably not going to work" but disabling finish asynchronously seems harsh.  I agree with John that it's not going to happen for 3.5.  

Given the amount of times users encounter missing artifact errors (site is not refreshed, the lost artifact repo bug, etc), I think it'd be better to put effort toward handling that error more gracefully and suggesting quickfixes.  Right now we say "error during collect phase...blah blah blah" and it would be better to state more clearly what is missing and present possible fixes (refresh the repo that is likely to contain it, etc.)
Comment 6 Eclipse Webmaster CLA 2019-09-06 15:31:50 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
Comment 7 Ed Merks CLA 2020-02-21 01:37:26 EST
This is relative to a UI that I don't see used today.