Bug 221655 - [plug-ins view] useless content description
Summary: [plug-ins view] useless content description
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, contributed
Depends on:
Blocks:
 
Reported: 2008-03-06 08:52 EST by Remy Suen CLA
Modified: 2009-04-13 13:09 EDT (History)
2 users (show)

See Also:


Attachments
Removed useless initial content description (1.26 KB, patch)
2008-05-30 11:21 EDT, Benedikt Arnold CLA
caniszczyk: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2008-03-06 08:52:44 EST
I20080304-1113

After the resolution of bug 220069, I realized that we have a bigger problem.

1. Make sure all instances of the 'Plug-ins' view is closed across all
perspectives.
2. Open the 'Plug-ins' view.
3. See the content description for the view, 'Plug-ins: Plug-ins View', and start rubbing your chin.

This content description is not helpful to the user in any way, shape, or form. The content description should either be hidden upon view construction or it should tell me 'Filter matched 109 of 128 plug-ins'.

One interesting thing is that once the view first gets constructed and then you perform an action like 'Add to Java Search' or 'Remove from Java Search', the content description will change from 'Plug-ins: Plug-ins View' - 'Filter matched 109 of 128 plug-ins', but I presume that is a separate matter.
Comment 1 Chris Aniszczyk CLA 2008-04-15 11:50:53 EDT
tagging bugday
Comment 2 Benedikt Arnold CLA 2008-05-30 11:21:45 EDT
Created attachment 102887 [details]
Removed useless initial content description

Hi,

I'd like to work on this bug. This is my first contribution to an eclipse.org project, so please don't hesitate with feedback :-)

I Removed the lines of code wich set up the content description to that useless value. Is that ok or should there be an content description like: "No filter" or something similar?

Cheers,
Ben
Comment 3 Chris Aniszczyk CLA 2008-05-30 11:55:57 EDT
I think that will do.

It's a bit too late for 3.4, however, this will go right into 3.5 once the stream is open.

Thanks for the contribution :)

We will have to get a face shot from you to go on the PDE Hall of Fame:
http://www.eclipse.org/pde/pde-ui/committers/committers.php
Comment 4 Remy Suen CLA 2008-07-24 14:50:11 EDT
Personally, I'd prefer that the view tell me how many plug-ins are currently filtered out (if any) instead of having the description hidden upon view construction (though I admit I did note that as a potential solution for this bug in comment 0).

Anyway, just dropping a ping here to the PDE team since it annoys me every time I see it. Sometimes I forget if I'm filtering any plug-ins or not and seeing X of Y or Y of Y would immediately relay this information to me, saving me the time required to click on the view's drop down menu and see what I have filtered out (if any).
Comment 5 Curtis Windatt CLA 2009-04-07 15:34:24 EDT
It's been a busy year and this contribution seems to have fallen off the radar.  I'll reassign it to myself and try and review it for M7.
Comment 6 Chris Aniszczyk CLA 2009-04-13 13:08:37 EDT
Thanks for you contribution! This works for me. I updated the patch to work against HEAD.

> 20090413