Bug 221607 - Generic Catalog Filtering for all Database Profile Types
Summary: Generic Catalog Filtering for all Database Profile Types
Status: NEW
Alias: None
Product: Data Tools
Classification: Tools
Component: Connectivity (show other bugs)
Version: 1.6   Edit
Hardware: PC Windows 2000
: P3 enhancement (vote)
Target Milestone: future   Edit
Assignee: Brian Fitzpatrick CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2008-03-05 18:01 EST by Linda Chan CLA
Modified: 2008-04-24 18:11 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Linda Chan CLA 2008-03-05 18:01:56 EST
Generic catalog filtering implementation for all database profile types that don't have own specific filtering functionality.
Current support of the filtering expression specified in the "Connection Filter Properties" page depends on the implementation a db-specific enablement project.  To make it easier for adopters to support this feature, it would be desirable for the connectivity framework to provide some "generic" implementation that any database profile types can opt-in (or opt-out).
Comment 1 Brian Fitzpatrick CLA 2008-03-06 16:41:26 EST
Will need to look into this.
Comment 2 Brian Fitzpatrick CLA 2008-03-11 18:32:27 EDT
Hey Linda...

In my preliminary testing, it appears that we were correct from our discussion yesterday. If just the default loaders are used, filtering is fine. It's where we have enablement plug-ins that override the default catalog loaders and aren't filter-aware that we have issues...

For example, MySQL overrides the entire process from top to bottom and ignores the filter. ASA may have the same issue.

MaxDB looks ok. Oracle should be ok. SQL Server should be ok. All the IBM profiles look ok. HSQLDB works fine. And Derby looks fine. 

So looks like we need to move the MySQL loaders to the override loader philosophy instead of wholesale replacing the catalog loader from the top down. And Sybase will have to do the same with the ASA loaders (and ASE if it is ever contributed).

So should we open a couple of BZ entries for those two areas specifically and close this bug?

--Fitz
Comment 3 Linda Chan CLA 2008-03-11 18:51:29 EDT
Thanks Fitz for the investigation.

How easy is it for enablement plugins to adopt the "default" filtering implementation?  The original intent of this bug is to extract, if necessary, and provide some basic filtering implementation; so that any enablement plugin can easily adopt and apply in its own catalog loader.
Comment 4 Brian Fitzpatrick CLA 2008-03-12 17:59:06 EDT
I can look at modifying the MySQL catalog loader and the Sybase ones once those teams have had a chance to work on them. Shouldn't be too tough -- maybe take a day or two -- to get the MySQL one done. I went through a similar process for Derby.

I'm thinking this could be an M7 task, since it shouldn't affect many folks. 
Comment 5 Brian Fitzpatrick CLA 2008-04-23 13:38:49 EDT
Linda, I don't think this is going to make it into Ganymede. I just don't have the time to commit to redoing the MySQL catalog loaders for this release, sorry. Should we assign this to the Zend folks to look at as time allows?
Comment 6 Linda Chan CLA 2008-04-23 15:32:16 EDT
It would be good to see if other contributors can help to make this into Ganymede.  Otherwise, can we do this for the next maintenance release?
Comment 7 Brian Fitzpatrick CLA 2008-04-23 16:11:01 EDT
I'll cc the Zend folks and ask for their help, but I don't see why this couldn't be put in the 1st maintenance release if it doesn't make it into Ganymede. This isn't an API change or feature change, it's merely taking into account some existing functionality to gain the filtering capabilities for MySQL.

Roy, would your team be able to look at migrating the custom catalog loader for MySQL over from implementing its own catalog loaders to simply extending the internal loaders as we've done with some of the other enablement plug-ins?