Description Neil Bartlett 2008-03-05 04:29:39 EST

Created attachment 91623 [details]
patch

In org.eclipse.equinox.cm, ConfigurationImpl breaks the contract for Object.equals(). The implementation is as follows:

   return pid.equals(((Configuration) obj).getPid());

Which will throw a ClassCastException when the obj parameter is not an instance of Configuration, causing problems if these objects are used in a collection or a JFace viewer etc. It should simply return false, eg:

   return (obj instanceof Configuration)
      && pid.equals(((Configuration) obj).getPid());


Regards,
Neil