Bug 221232 - sample jsp generation from context menu of client proxy doesn't respect server settings
Summary: sample jsp generation from context menu of client proxy doesn't respect serve...
Status: CLOSED FIXED
Alias: None
Product: WTP Webservices
Classification: WebTools
Component: jst.ws (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P2 major (vote)
Target Milestone: 3.0 M7   Edit
Assignee: Gilbert Andrews CLA
QA Contact: Kathy Chan CLA
URL:
Whiteboard: PMC
Keywords: contributed, PII
Depends on:
Blocks:
 
Reported: 2008-03-03 16:56 EST by Kathy Chan CLA
Modified: 2009-03-24 15:32 EDT (History)
3 users (show)

See Also:
kathy: pmc_approved? (david_williams)
raghunathan.srinivasan: pmc_approved+
kathy: pmc_approved? (naci.dai)
kathy: pmc_approved? (deboer)
neil.hauge: pmc_approved+
kathy: pmc_approved? (kaloyan)

Attachments
This patch adds the combos (19.63 KB, patch)
2008-04-25 22:08 EDT, Gilbert Andrews CLA 		no flags Details | Diff
modified patch (19.84 KB, patch)
2008-04-29 10:09 EDT, Kathy Chan CLA 		bjorn.freeman-benson: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kathy Chan CLA 2008-03-03 16:56:09 EST 
Sample jsp generation from context menu of client proxy doesn't respect server settings.  So if the user has mulitiple servers in the workspace, it will always pick the first one.  This might result in running the sample JSP in the server which does not support a particular sample JSP test facility.

We might need to introduce a combo box to let the user pick the correct server.
Comment 1 Kathy Chan CLA 2008-03-03 16:56:48 EST 
Targetting to WTP 3.0 M6 because of UI changes involved.
Comment 2 Kathy Chan CLA 2008-04-03 12:45:10 EDT 
Deferring out from M6.  Please try to have the fix early next week as this is affecting some adoptors as well.
Comment 3 Kathy Chan CLA 2008-04-17 15:04:49 EDT 
We're requesting PMC approval to make this UI change (adding a combo box in the Web services sample JSP popup) for M7.  This fix is required by an adopter.
Comment 4 Gilbert Andrews CLA 2008-04-25 22:08:39 EDT 
Created attachment 97708 [details]
This patch adds the combos
Comment 5 Gilbert Andrews CLA 2008-04-25 22:11:38 EDT 
I have added two combo boxes to the popup. This allows you to choose the type pf server and choose the serverinstance. 

If there is no server the boxes are not enabled. 

If there are no instances available the wizrd will create an instance for you upon selecting finish.
Comment 6 Kathy Chan CLA 2008-04-29 10:09:36 EDT 
Created attachment 97981 [details]
modified patch

Slight modification to Gil's patch:

- Assign unique context IDs and update descriptions for Kate.
- Use unique context ID and tool tips for the 2 combos including adding the new tooltips to properties files.
- Removed the call to serverInstanceTypeCombo_.addSelectionListener all together since we are not doing anything in the listener.
Comment 7 Kathy Chan CLA 2008-04-29 10:10:18 EDT 
The modified patch has been committed and released to HEAD as v200804291407.
Comment 8 Kathy Chan CLA 2008-06-05 16:20:07 EDT 
Verified in 05/23 WTP 3.0 driver.
Comment 9 Davoud Salahi Rad CLA 2009-03-24 15:32:37 EDT 
Since you have been invloved with the patch for the combo boxes, any ideas that could help in fixing bug 247535?

Thanks,
Davoud