Bug 221130 - [search] No fine-grain search for instanceof criteria
Summary: [search] No fine-grain search for instanceof criteria
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.4 M6   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-03 07:26 EST by Philipe Mulet CLA
Modified: 2008-03-26 04:33 EDT (History)
3 users (show)

See Also:


Attachments
Proposed patch (5.28 KB, patch)
2008-03-04 05:02 EST, Frederic Fusier CLA
no flags Details | Diff
JDT/UI patch for this new fine grain flag (3.95 KB, patch)
2008-03-04 05:53 EST, Frederic Fusier CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philipe Mulet CLA 2008-03-03 07:26:29 EST
Build 3.4M5

Along the lines of providing fine-grain search functionality, it feels the instance-of pattern got ommitted.
Comment 1 Philipe Mulet CLA 2008-03-03 07:30:03 EST
(I was just trying to look for occurrences of 'instanceof Wildcard' to solve bug 221110)
Comment 2 Frederic Fusier CLA 2008-03-03 07:44:41 EST
As this would imply an API addition in IJavaSearchConstants, we need to decide if this must be done for M6 or defer to next release...
Comment 3 Frederic Fusier CLA 2008-03-04 05:02:54 EST
Created attachment 91489 [details]
Proposed patch

The fix for this functionality is definitely simple...
Comment 4 Frederic Fusier CLA 2008-03-04 05:52:43 EST
Released for 3.4M6 in HEAD stream.
Comment 5 Frederic Fusier CLA 2008-03-04 05:53:52 EST
Created attachment 91494 [details]
JDT/UI patch for this new fine grain flag

Martin,

Here's the patch for the corresponding JDT/UI change

HTH
Comment 6 Martin Aeschlimann CLA 2008-03-04 08:21:50 EST
UI patch released (with slight changes) > 20080304 (for 3.4 M6). Thanks Frederic!
Comment 7 Eric Jodet CLA 2008-03-26 04:33:30 EDT
Verified for 3.4M6 using build I20080324-1300