Bug 220999 - [api] Need to change class SystemSelectRemoteFileAction to use SystemRemoteFileDialog
Summary: [api] Need to change class SystemSelectRemoteFileAction to use SystemRemoteFi...
Status: RESOLVED DUPLICATE of bug 220995
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 M6   Edit
Assignee: Xuan Chen CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2008-02-29 15:30 EST by Xuan Chen CLA
Modified: 2010-11-26 11:29 EST (History)
0 users

See Also:

Attachments
patch for this problem. (7.13 KB, text/plain)
2008-02-29 16:13 EST, Xuan Chen CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xuan Chen CLA 2008-02-29 15:30:37 EST 
Unlike SystemSelectRemoteFolderAction, SystemSelectRemoteFileAction still uses 
SystemSelectRemoteFileOrFolderDialog, instead of SystemRemoteFileDialog.

SystemSelectRemoteFileOrFolderDialog has been deprecated. 
I think the reason that SystemSelectRemoteFileAction hasn't been changed is because it was not used by any components in current open RSE code.

But this action is needed by IBM product, so I will update it to use SystemRemoteFileDialog (which is a sub class of SystemRemoteResourceDialog.

Like SystemSelectRemoteFolderAction, an API setCustomViewerFilter() will also need to be added.
Comment 1 Xuan Chen CLA 2008-02-29 16:13:53 EST 
Created attachment 91248 [details]
patch for this problem.

This is the fix for SystemSelectRemoteFileAction so that it will use SystemRemoteFileDialog.

Since there are lots of similar code for SystemSelectRemoteFileAction and SystemSelectRemoteFolderAction, we may need to change so that SystemSelectRemoteFolderAction is derived from SystemSelectRemoteFileAction.
Comment 2 Xuan Chen CLA 2008-02-29 16:15:30 EST 
I've committed the changes.
Comment 3 Martin Oberhuber CLA 2008-03-03 08:49:08 EST 
Currently, SystemSelectRemoteFileAction compiles with tons of warnings. We have a guideline that when modifying a file, the file should not be committed without addressing the warnings. Please work on the warnings.

Since this is addressed now, we should get rid of SystemSelectRemoteFileOrFolderDialog completely. I filed bug 221138 for this work, to be completed by 3.0M6 (API Freeze).

This change is an API addition because of adding
   public void setCustomViewerFilter(SystemActionViewerFilter)
Comment 4 Xuan Chen CLA 2008-03-03 11:48:28 EST 
Reopen to address warning in this class.
Comment 5 Xuan Chen CLA 2008-03-10 16:41:03 EDT 
I committed the fixes to this bug with bug 220995.  So mark it as dup of 220995.

*** This bug has been marked as a duplicate of bug 220995 ***
Comment 6 Xuan Chen CLA 2010-11-26 11:29:40 EST 
Close it.