Bug 220556 - FullSourceWorkspaceSearchTests#testSearchPackageDeclarations() perf test is invalid
Summary: FullSourceWorkspaceSearchTests#testSearchPackageDeclarations() perf test is i...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M6   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance, test
Depends on:
Blocks:
 
Reported: 2008-02-27 09:36 EST by Frederic Fusier CLA
Modified: 2008-03-26 04:41 EDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (1.56 KB, patch)
2008-03-20 06:49 EDT, Frederic Fusier CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frederic Fusier CLA 2008-02-27 09:36:41 EST 
Last integration build I20080225-0800 shows serious performance regressions for search package declarations tests (especially for workspace: between -5.1% and -15.7%). May be an impact of external class folder support release but it looks like these tests also got some troubles for several weeks...
Comment 1 Frederic Fusier CLA 2008-02-27 09:39:53 EST 
Previous comment should read "build I20080226-1155"...
Comment 2 Frederic Fusier CLA 2008-03-17 16:45:56 EDT 
The regression was in fact only in FullSourceWorkspaceSearchTests#testSearchPackageDeclarationsWorkspace() test but was a side effect bug 222399 and our local perf results show that its now fixed in HEAD.

The other test is in fact invalid as it lasts only 3ms! So, as there's already a test for this kind of search, I will just disable this duplicate test in the JDT/Core Search performance test suite.
Comment 3 Frederic Fusier CLA 2008-03-20 06:49:57 EDT 
Created attachment 93016 [details]
Proposed patch
Comment 4 Frederic Fusier CLA 2008-03-20 06:50:28 EDT 
Released for 3.4M6 in HEAD stream.
Comment 5 Eric Jodet CLA 2008-03-26 04:41:53 EDT 
Verified in the code for 3.4M6 using build I20080324-1300