Community
Participate
Working Groups
While playing with p2 3.4M5 today I noticed that it would be cool to show the current download speed when the progress view is open and showing the download job.
Ideally this could actually be embedded in the progress subTask messages in the ECF transfer job, and we would inherit this for free along with other ECF clients.
I've worked on it and will attach a patch against org.eclipse.ecf.provider.filetransfer HEAD soon. May someone please move this issue to ECF bugzilla product. Or should I file a bug there directly?
(In reply to comment #2) > I've worked on it and will attach a patch against > org.eclipse.ecf.provider.filetransfer HEAD soon. > May someone please move this issue to ECF bugzilla product. Or should I file a > bug there directly? > Benjamin...you are completely welcome to submit the patch here. Issue/caveat though: People on this bug should be made aware that there is bug 220441 that Thomas and I are working on at this moment...and the changes for 220441 will result in changes to org.eclipse.ecf.provider.filetransfer...meaning that the patch work submitted here might need to change significantly.
(In reply to comment #3) Thanks for feedback, Scott! I'll wait for bug 220441 to be fixed to adapt and submit my patch (which is working well on current HEAD :op)
(In reply to comment #4) > (In reply to comment #3) > > Thanks for feedback, Scott! > I'll wait for bug 220441 to be fixed to adapt and submit my patch (which is > working well on current HEAD :op) > Sounds good. I'm hopeful that bug 220441 will be addressed over next day (we have an approach that I think will work fine for Thomas' and others needs). I expect to get it into the 3/3 integration build...hopefully along with this addition too. For (my) curiosity's sake maybe you would post the patch you have now?
Created attachment 91063 [details] org.eclipse.ecf.provider.filetransfer patch Here it is :) Feel free to give some feedback!
Created attachment 91064 [details] org.eclipse.ecf.provider.filetransfer patch Here it is :) Feel free to give some feedback!
Created attachment 91066 [details] org.eclipse.ecf.provider.filetransfer patch Here it is :) Feel free to give some feedback!
Created attachment 91065 [details] org.eclipse.ecf.provider.filetransfer patch Here it is :) Feel free to give some feedback!
Created attachment 91067 [details] org.eclipse.ecf.provider.filetransfer patch Here it is :) Feel free to give some feedback!
Created attachment 91068 [details] mylyn/context/zip
OMG, sorry for spamming. Mylyn seems to mess things up when the bugzilla is down and you hit frenetically "Finish" button on the submit patch wizard :p
(In reply to comment #10) > Created an attachment (id=91067) [details] > org.eclipse.ecf.provider.filetransfer patch > > Here it is :) > Feel free to give some feedback! > Looks fine to me. I see you dynamically change the task name with monitor.setTaskName. One other thing I might add is a method in filetransfer API for clients to get at the rate e.g. via IIncomingFileTransfer.getDownloadRate() (or something like that). I'll plan on adding this in immediately after we get bug 220441 in place. Thanks!
(In reply to comment #13) > Looks fine to me. Good :) > One other thing I might add is a method in filetransfer API for clients to get > at the rate e.g. via IIncomingFileTransfer.getDownloadRate() (or something like > that). +1! I think that IIncomingFileTransfer#getStartTime() (or something like that...!) might be great too
(In reply to comment #14) > (In reply to comment #13) > > Looks fine to me. > > Good :) > > > One other thing I might add is a method in filetransfer API for clients to get > > at the rate e.g. via IIncomingFileTransfer.getDownloadRate() (or something like > > that). > > +1! > I think that IIncomingFileTransfer#getStartTime() (or something like that...!) > might be great too > Benjamin, bug 220441 is fixed, so if you wouldn't mind re-creating your patch and attaching to this bug I will apply as soon as it is available.
Yap :)
Created attachment 91242 [details] Patch synced for HEAD That might be great, later, to have an AbstractFileTransfer class in which stuff like the transfer rate computation could stand...
(In reply to comment #17) > Created an attachment (id=91242) [details] > Patch synced for HEAD > > That might be great, later, to have an AbstractFileTransfer class in which > stuff like the transfer rate computation could stand... > Applied patch with only minor changes from attachment and released to HEAD. Added contribution to ECF ip log. RE: your point about AbstractFileTransfer...yes, it's a reasonable idea. Just haven't done it yet. I would like to think about best way to represent the additional API...might be better as an adapter (e.g. IFileTransferRateInfo or some such)...or it might make more sense directly on IIncomingFileTransfer. Thanks Benjamin for the contribution! It should appear in p2 UI in 3/4/2008 integration build. Marking this bug as fixed.
Awesome guys!
oops. Forgot the resolution. Thanks Gunnar for nice words.
closing.
