Bug 220020 - [api][breaking] SystemFileTransferModeMapping should be internal
Summary: [api][breaking] SystemFileTransferModeMapping should be internal
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 2.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.0 M6   Edit
Assignee: Martin Oberhuber CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2008-02-22 14:55 EST by Martin Oberhuber CLA
Modified: 2008-02-22 15:31 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2008-02-22 14:55:40 EST
This is not really an API change, since the Javadoc for SystemFileTransferModeMapping had already specified that clients are not allowed to instantiate or subclass the class.

The class should be moved to an "internal" package, and implementation of clone() should be fixed along the way.
Comment 1 Martin Oberhuber CLA 2008-02-22 15:31:44 EST
Actually found that SystemFileTransferModeRegistry should also be internal.
In this case it's really a breaking API change, since clients used to use
   SystemFileTransferModeRegistry.getInstance()
This is now changed to use
   RemoteFileUtility.getSystemFileTransferModeRegistry()
instead.

Along the way, protected RemoteFile#fullyQualifiedName is also removed from API, since it was obsolete (nowhere set or used) so removing it makes sure no bugs occur due to accessing an uninitialized field. Cleaned up Javadoc along the way.

Change committed:

[220020][api][breaking] SystemFileTransferModeRegistry should be internal
  SystemFileTransferModeMapping
  SystemFileTransferModeRegistry
  UniversalPreferencePage
  UniversalFileTransferUtility
  RemoteFileUtility
  FileServiceSubSystem
  RemoteFile
  RemoteFileEmpty
  RemoteFileRoot
  DStoreFileSubSystemConfiguration
  LocalFileSubSystemConfiguration


Migration Notes: Replace
   SystemFileTransferModeRegistry.getInstance()
by
   RemoteFileUtility.getSystemFileTransferModeRegistry()