Bug 220015 - Bundles Launch Filtered Tree, Nasty Revert Bug
Summary: Bundles Launch Filtered Tree, Nasty Revert Bug
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M6   Edit
Assignee: Ian Bull CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on: 207638
Blocks:
  Show dependency tree
 
Reported: 2008-02-22 13:51 EST by Ian Bull CLA
Modified: 2008-03-26 16:22 EDT (History)
1 user (show)

See Also:


Attachments
org.eclipse.pde.ui (2.29 KB, patch)
2008-03-24 19:45 EDT, Ian Bull CLA
no flags Details | Diff
mylyn/context/zip (922 bytes, application/octet-stream)
2008-03-24 19:45 EDT, Ian Bull CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Bull CLA 2008-02-22 13:51:00 EST
If the bundle launch filtered tree is currently filtering, and someone selects revert, it doesn't work.  This is because the PDE does everything on the actual TreeItems, and the tree items are being filtered.

I would like to simply clear the filtered tree whenever a revert happens, however, the only way to clear the filtered tree is to clear the text, and this schedules an asynchronous job.  I have requested the addition of a protected method to refresh immediately.

207638: [Dialogs] Add a way to refresh a filtered tree, immediately
https://bugs.eclipse.org/bugs/show_bug.cgi?id=207638
Comment 1 Ian Bull CLA 2008-02-22 22:00:41 EST
I have a patch for this, but I need the filtered tree to change one of its fields from private to protected first.
Comment 2 Ian Bull CLA 2008-03-24 19:45:26 EDT
Created attachment 93333 [details]
org.eclipse.pde.ui

This now clears the filtered tree immediately when revert is called, so that all the tree items are placed back in the tree and revert can update them as necessary.
Comment 3 Ian Bull CLA 2008-03-24 19:45:29 EDT
Created attachment 93334 [details]
mylyn/context/zip
Comment 4 Chris Aniszczyk CLA 2008-03-24 19:48:45 EDT
going in for M6
Comment 5 Chris Aniszczyk CLA 2008-03-25 10:17:51 EDT
Thanks Ian.

> 20080325
Comment 6 Ian Bull CLA 2008-03-26 16:22:08 EDT
Verified in  I20080325-2233.