Bug 219981 - Select all in Bundles Launch Configuration is Destructive
Summary: Select all in Bundles Launch Configuration is Destructive
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M6   Edit
Assignee: Ian Bull CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-02-22 11:15 EST by Ian Bull CLA
Modified: 2008-02-23 12:34 EST (History)
1 user (show)

See Also:

Attachments
org.eclipse.pde.ui (5.91 KB, patch)
2008-02-22 20:24 EST, Ian Bull CLA 		no flags Details | Diff
mylyn/context/zip (119.43 KB, application/octet-stream)
2008-02-22 20:24 EST, Ian Bull CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Bull CLA 2008-02-22 11:15:55 EST 
If the filtered checkbox has any filtered text, when select all (or deselect all) is chosen, Auto-Start and Start-Level values are removed.

Steps to reproduce.
1. change the start-level on a bundle
2. type some garbage into the filtered text box (this should filter all bundles)
3. hit select all
4. clear the box
5. notice that the start-level forgot its value

This requires the patch from 

207064: Bundles Launch Configuration should support filtering
https://bugs.eclipse.org/bugs/show_bug.cgi?id=207064
Comment 1 Chris Aniszczyk CLA 2008-02-22 11:21:35 EST 
ya we should fix this or Simon will get upset ;)
Comment 2 Ian Bull CLA 2008-02-22 11:28:38 EST 
Yep, I will.
Comment 3 Ian Bull CLA 2008-02-22 20:24:49 EST 
Created attachment 90542 [details]
org.eclipse.pde.ui

Select / Deselect all now only resets things that are displayed.  

I also removed two methods (set and get children) that I added to named element.  These methods were not really needed.  I added these when select / deselect all worked on all elements (not just the filtered ones), but since we changed this behaviour, they are not needed anymore.
Comment 4 Ian Bull CLA 2008-02-22 20:24:53 EST 
Created attachment 90543 [details]
mylyn/context/zip
Comment 5 Chris Aniszczyk CLA 2008-02-23 12:34:03 EST 
done. danke sir!