Description Elena Laskavaia 2008-02-21 15:34:09 EST

Created attachment 90401 [details]
4.0 patch

In 3.0 when you add breakpoint from console, like b * 0x4804136c if source has debug info it was adding breakpoint with correct source info, like main.c:25,
so it is possible to navigate.
In 4.0 it adds only address line main.exe[address:0x4804136c] which opens binary editor on double click if you lucky (if not lucky it open binary file in text editor).

Expected: if address has file and line it should create breakpoint in same as as it created when adding breakpoints from disassembly view, i.e. so navigation works.





Proposed fix attached (please somebody apply before 4.0.3 is built!!):
- use same method as used by ToggleBreakpointAdapter (which is used when breakpoint set from Disassembly view) to create address breakpoint but with file and line, if available. If not use binary as before.

Tests performed:
- adding breakpoint from Disassembly works as before
- adding breakpoint from console adds main.c[0x4804136c] (line is not visible but it navigates correctly)
- with no debug info it adds main.exe[address:0x4804136c] as before
- with debug info but when file is not found it opens file not found editor