219848 – Fragments should be able to enter EE's too

Bug 219848 - Fragments should be able to enter EE's too

Summary: Fragments should be able to enter EE's too

Status:	RESOLVED FIXED

Alias:	None

Product:	PDE
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	3.3
Hardware:	PC Windows XP

Importance:	P3 normal (vote)
Target Milestone:	3.4 M6
Assignee:	charlie
QA Contact:

URL:
Whiteboard:
Keywords:	bugday, contributed

Depends on:
Blocks:

Reported:	2008-02-21 14:36 EST by Brian Bauman
Modified:	2008-03-05 10:23 EST (History)
CC List:	3 users (show)

See Also:

Attachments
mylyn/context/zip (1015 bytes, application/octet-stream) 2008-02-27 12:24 EST, Chris Aniszczyk	no flags	Details
FragmentContentPage patch (5.73 KB, patch) 2008-03-04 14:03 EST, charlie	no flags	Details \| Diff
mylyn/context/zip (2.31 KB, application/octet-stream) 2008-03-04 14:03 EST, charlie	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Brian Bauman

2008-02-21 14:36:44 EST

Fragments get no love these days :)  PDE recently added the ability to specify an Execution Environment through the New Plug-in wizard.  This ability should be extended to the New Fragment wizard also.

Comment 1 Chris Aniszczyk

2008-02-27 12:20:29 EST

Want to give this one a try Charlie?

I'll work on attaching a context.

Comment 2 Chris Aniszczyk

2008-02-27 12:24:52 EST

I'm attaching a context with two classes:

FragmentContentPage and PluginContentPage.

FragmentContentPage is where you will need to make the modifications. PluginContentPage has example code in it to add an Execution Environment (EE) selection. We basically want to mimick the same functionality but in the New Fragment wizard. I'd just add the EE selection to be under the 'Fragment Provider' section.

Comment 3 Chris Aniszczyk

2008-02-27 12:24:56 EST

Created attachment 90897 [details]
mylyn/context/zip

Comment 4 charlie

2008-03-04 14:03:38 EST

Created attachment 91551 [details]
FragmentContentPage patch

For version 1.26.  Added createExecutionEnviornmentControls, updated updateData to add EE choice to fData, updated validatePage() for the EE choice.

Comment 5 charlie

2008-03-04 14:03:41 EST

Created attachment 91552 [details]
mylyn/context/zip

Comment 6 charlie

2008-03-04 14:04:43 EST

Ok patch attached, what next :) ?

Comment 7 Chris Aniszczyk

2008-03-05 10:10:14 EST

Awesome Charlie, thanks for the patch, it will get in for M6 :)

Comment 8 Chris Aniszczyk

2008-03-05 10:23:16 EST

fixed in HEAD.

> 20080305

I updated the patch to make the layout a bit better as the current patch didn't space the controls properly.

Thanks for the contribution Charlie!