Bug 219770 - Actions on extension point declaration in Outline view for source page don't work
Summary: Actions on extension point declaration in Outline view for source page don't ...
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M6   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-21 06:53 EST by Markus Keller CLA
Modified: 2008-02-21 13:56 EST (History)
2 users (show)

See Also:

Attachments
Patch for review (3.79 KB, patch)
2008-02-21 12:08 EST, Curtis Windatt CLA 		no flags Details | Diff
mylyn/context/zip (974 bytes, application/octet-stream)
2008-02-21 13:56 EST, Chris Aniszczyk CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2008-02-21 06:53:06 EST 
M20080123-0800 and 3.4

- open plugin.xml source editor
- in the Outline view, select an extension point declaration
- context menu actions Show Descritption and Open Schema don't work (dialog saying "... cannot be found.")
Comment 1 Chris Aniszczyk CLA 2008-02-21 09:38:56 EST 
It works for me... are you sure the schemas are on disk?
Comment 2 Markus Keller CLA 2008-02-21 10:22:51 EST 
Yes, I tried it with fresh workspaces and checking out org.eclipse.core.expressions from CVS.
Comment 3 Markus Keller CLA 2008-02-21 10:25:37 EST 
It works on forms pages but fails on the source (plugin.xml) page.
Comment 4 Chris Aniszczyk CLA 2008-02-21 10:28:37 EST 
Curtis, can you reproduce this?
Comment 5 Curtis Windatt CLA 2008-02-21 11:09:01 EST 
Yes, I can reproduce in I20080207-1530.
Comment 6 Curtis Windatt CLA 2008-02-21 11:09:57 EST 
It works when selecting an extension, but not when selecting a extension point.
Comment 7 Curtis Windatt CLA 2008-02-21 11:16:07 EST 
However, when trying to debug in a runtime workbench, there is no problem opening the schema.
Comment 8 Curtis Windatt CLA 2008-02-21 11:22:01 EST 
I suppose after adding so many comments to this bug I should assign it to myself.

Got it to reproduce in the target, not sure why it didn't happen a minute ago.  The problem is that the action is receiving different values when the input changes.  When the editor is open we get the entire point id (org.eclipse.core.variables.valueVariables) while with the source open we only get the last section (valueVariables).
Comment 9 Curtis Windatt CLA 2008-02-21 12:08:57 EST 
Created attachment 90372 [details]
Patch for review

When creating an outline page for a PDE editor, we pass the editor to the constructor.  The editor is used to get the model and generate the full extension point id.  When creating an outline page for a source page, we don't pass the editor in.  The fix is to allow the source page to pass it's editor to the outline.
Comment 10 Chris Aniszczyk CLA 2008-02-21 12:37:05 EST 
cool!
Comment 11 Chris Aniszczyk CLA 2008-02-21 13:55:57 EST 
done
Comment 12 Chris Aniszczyk CLA 2008-02-21 13:56:00 EST 
Created attachment 90387 [details]
mylyn/context/zip