Bug 219592 - "Delete From Model" generate errors and corrupt editor
Summary: "Delete From Model" generate errors and corrupt editor
Status: CLOSED FIXED
Alias: None
Product: Ecoretools
Classification: Modeling
Component: General (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P1 critical
Target Milestone: Past   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 226150
Blocks:
  Show dependency tree
 
Reported: 2008-02-20 08:52 EST by Jacques LESCOT CLA
Modified: 2008-07-30 11:48 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jacques LESCOT CLA 2008-02-20 08:52:08 EST 
Quite easy to reproduce :
1. Create a new diagram with two EClasses
2. Try to "Delete From Model" one of the two EClasses

The EClass is removed from the model, but the graphical occurrence is still present in the diagram : the problem is probably due to a bad layout of remaining graphical elements :
"Argument 'nodes' contains objects which have a different parent containment"

However when saving and reopening the model, elements are refreshed correctly without corrupting the domain and diagram files : this is the good news !
Comment 1 Jacques LESCOT CLA 2008-02-22 03:45:10 EST 
It only happens when trying to delete an element at the top level of the diagram : the problem may be due to a bad use of the CanonicalEditPolicy that was adapted for our needs.
Comment 2 Jacques LESCOT CLA 2008-04-08 12:32:41 EDT 
There are two solutions to fix this bug :
  - fix the GMF bug in the ContainerEditPolicy (line 316) : bug 226150 that check whether the EditPart is active or not.
  - remove the workaround done in the EcoreDiagramEditor (line 344) to fix the bug 203520

Many thanks to David for the bug resolution !
Comment 3 Jacques LESCOT CLA 2008-04-09 03:49:32 EDT 
Remove the workaround done in the EcoreDiagramEditor class to fix the
bug 203520. Bug 226235 is then introduced but with a lower severity.
Comment 4 Jacques LESCOT CLA 2008-07-30 11:48:30 EDT 
Close fixed bugs