Bug 21957 - 'refactor rename' allows subpackage name to start with a space.
Summary: 'refactor rename' allows subpackage name to start with a space.
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 2.1 M3   Edit
Assignee: Jerome Lanneluc CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-07-26 11:05 EDT by Chris McLaren CLA
Modified: 2002-11-13 06:42 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris McLaren CLA 2002-07-26 11:05:18 EDT 
refactor -> rename on a package

the text field will catch most invalid package names, 
such as ending with whitespace, or whitespace in the middle of an identifier, 
etc, but choose to rename to:

"package. subpackage" with the space after the "." and it will allow you
to continue the refactoring, only to get an 'unexpected exception' dialog 
during the refactoring process.
Comment 1 Adam Kiezun CLA 2002-07-26 11:10:52 EDT 
JavaConventions bug
Comment 2 Olivier Thomann CLA 2002-07-26 15:03:58 EDT 
The problem is not a bug in the JavaConventions. It is possible to have a
package name like:
package test. test1;

This should result in a test.test1 package name. So the creation of the folder
is incorrect. But such a name with whitespaces could be theorically passed as a
package name.
Comment 3 Philipe Mulet CLA 2002-07-29 06:20:50 EDT 
Not sure we should support it at the API level... unless all our APIs taking 
qualified names did behave in the same way.

Need to investigate and make a move to be consistent (if necessary).
Comment 4 Jerome Lanneluc CLA 2002-10-31 13:21:03 EST 
Now tolerate to create a package fragment handle with spaces in its name. These 
spaces are removed right away.
Comment 5 David Audel CLA 2002-11-13 06:42:15 EST 
Verified.