Bug 219260 - [dstore][regression] Cannot connect to dstore daemon if not using SSL
Summary: [dstore][regression] Cannot connect to dstore daemon if not using SSL
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P1 major (vote)
Target Milestone: 3.0 M5   Edit
Assignee: Martin Oberhuber CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 218685
  Show dependency tree
 
Reported: 2008-02-17 11:32 EST by David Dykstal CLA
Modified: 2008-02-19 22:28 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Dykstal CLA 2008-02-17 11:32:31 EST 
I created a Unix connection using the defaults and started up a rse daemon on the localhost. On a Europa build connecting will complete. In the M5 Ganymede build connecting hangs and doesn't appear to time out. It looks like the initial SSL connection is not returning. I'm not sure if this is a Macintosh only problem with the dstore server or if it is more widespread.

Dave M or Kevin D - please attempt with a non-macintosh with the build candidate.
Comment 1 Martin Oberhuber CLA 2008-02-18 05:45:23 EST 
Reproduced with Linux -> Linux DStore Daemon, Windows -> Linux DStore Daemon.

Connecting to DStore-RExec works (I tested this during my standard milestone sanity check), but connecting via the daemon always fails.

I assume that this is a regression due to bug 218685.

I'll need a fix by 1pm latest to include it into the M5 builds. And those responsible for dstore milestone testing owe me a box of beer for the late-breaking extra work.
Comment 2 Xuan Chen CLA 2008-02-18 13:34:18 EST 
I tried, and it seems for dstore linux, there is no problem for me.
But I got hang in Windows dstore dameon.
Comment 3 Martin Oberhuber CLA 2008-02-18 13:38:21 EST 
From Kevin Doyle: It looks like we are always attempting to do SSL first then if it time's out we try non-SSL.  Problem is we no longer set a timeout since non was specified.  Looks like a regression from bug 218685.

Fix is to fall back to the default timeout of 10000 msec if no timeout was specified. This brings back old behavior in the default case.

Problem is that there does not seem to be a way to specify the dstore timeout. There is a prefs page listing a default timeout of 30000 but it does not seem to apply. Thus bug 218685 needs to be re-opened due to the fix.

Fix committed:
[219260][dstore][regression] Cannot connect to dstore daemon
   ClientConnection.java v1.18

Please verify with the next M5 candidate.
Comment 4 Martin Oberhuber CLA 2008-02-18 13:44:23 EST 
fixed.
Comment 5 Martin Oberhuber CLA 2008-02-18 14:01:14 EST 
Please verify with
   http://download.eclipse.org/dsdp/tm/downloads/drops/S-3.0M5-200802181400/
when it becomes available.
Comment 6 Xuan Chen CLA 2008-02-19 22:28:33 EST 
Verified the fix using M5 driver.
(tested in Windows and Linux)