Comment 1 Vadim Dmitriev 2008-03-09 22:26:49 EDT

Created attachment 92002 [details]
DT support for several trinidad tags

I implemented several attribute types and symbol factories you may find useful for DT support for trinidad tags. Short description is within attached archive.

Tested it with WTP 2.0.2 release.

Comment 2 Gerry Kessler 2008-03-10 14:35:32 EDT

Vadim, thank you very much for the patch.  We would like to integrate some or all of your contribution into our plugins.   That will require it to go through an IP review in the same way as your 191827 patch.   

Please confirm the following:
1.  Confirm you wrote the code,
2.  Confirm you have the rights to donate the code to Eclipse,
3.  Confirm that you are submitting the code for inclusion in future Eclipse
releases under the Eclipse Public License.

Comment 3 Vadim Dmitriev 2008-03-10 14:59:04 EDT

1.  For different reasons small portions of code were derived from classes included in org.eclipse.jst.jsf.*  (methods 'private' modifier mainly). All other code in the attachment was written by me.
2.  I confirm I have the rights to donate the code to Eclipse,
3.  I confirm that I'am submitting the code for inclusion in future Eclipse
releases under the Eclipse Public License.

Comment 4 Raghunathan Srinivasan 2008-03-13 15:23:42 EDT

This patch has passed the IP approval with the following comment:

Please ensure the default Eclipse copyright and license notice header is
attached to each file before checkin to CVS/SVN.  

Comment 5 Ian Trimble 2008-03-25 15:16:27 EDT

Status Update.

Support continues to be added incrementally. Source validation support is fairly complete. Palette information support continues to evolve. Advanced property page support has been implemented.

Tag conversion support has been added for the following tags, so far:
 - tr:chart
 - tr:commandButton
 - tr:commandLink
 - tr:document
 - tr:form
 - tr:goButton
 - tr:goLink
 - tr:icon
 - tr:inputText
 - tr:message
 - tr:messages
 - tr:outputFormatted
 - tr:outputLabel
 - tr:outputText
 - tr:panelTabbed
 - tr:separator
 - tr:showDetailItem
 - tr:spacer
 - trh:body
 - trh:head
 - trh:html
 - trh:styleSheet

Work continues...

Comment 6 Raghunathan Srinivasan 2008-04-02 13:10:40 EDT

Support for the Trinidad JSP tags is one of the main feature in this release. The Trinidad library has around 110 components. In M6, the Source page of the WPE has all the planned support for building a page with these tags. However, the Design-time rendering of these tags is only partially complete. We plan to complete a fair number of the tags by M7.

Comment 7 David Williams 2008-04-08 18:03:54 EDT

So ... this is just "new feature"? Right? 

Please clarify (for communication to others) if there are any UI or PII changes as a result of this added support. (I don't think so, from my quick read, but not sure). 

Comment 8 Raghunathan Srinivasan 2008-04-09 14:41:31 EDT

(In reply to comment #7)
> So ... this is just "new feature"? Right? 
> Please clarify (for communication to others) if there are any UI or PII changes
> as a result of this added support. (I don't think so, from my quick read, but
> not sure). 

There is no UI change in that the main WPE views such as the Editor, Outline, Property is not going to change. The only 'UI' change you will see is that new tags will be rendered when added to a page.

There could be few new strings that need to be translated (NLS)

Comment 9 Ian Trimble 2008-04-25 16:18:06 EDT

This task is considered complete for the Ganymede release. There remains work to be done to achieve full support, but we simply ran out of time and people. We will further the level of support in subsequent releases.

Please see http://wiki.eclipse.org/Support_for_the_Apache_MyFaces_Trinidad_Tag_Library for information regarding which tags do not yet have full support.

Please log issues with support for specific Trinidad tags as separate bug reports, rather than attaching to this "umbrella" bug (but please don't log bugs simply saying we fail to fully support a tag which is listed on the page linked to above - we know!).

Comment 10 Ian Trimble 2008-06-17 17:12:35 EDT

Closing for now. Support is not 100% complete, but support for the specified target is complete.