Bug 219098 - [api] FileServiceSubSystem should not be final
Summary: [api] FileServiceSubSystem should not be final
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 2.0   Edit
Hardware: All All
: P2 enhancement (vote)
Target Milestone: 3.0 M5   Edit
Assignee: Martin Oberhuber CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks: 218947
  Show dependency tree
 
Reported: 2008-02-15 09:45 EST by Martin Oberhuber CLA
Modified: 2008-02-15 09:50 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2008-02-15 09:45:14 EST 
+++ This bug was initially created as a clone of Bug #218947 +++

There are cases (like bug 218947) where users want to override behavior of FileServiceSubsystem, but they can't since the class is final.

It looks like the class was originally made final in order to encourage making all configuration in the IFileService instead of the subsystem. But it turns out that the service is not sufficient at least for some cases.

We should discourage overriding FileServiceSubSystem, but not forbid it. Therefore, the "final" modifier should be removed.

Note that this is a backward compatbile API change; however, if we should decide we'd want to add the "final" modifier back later on, it would be a breaking API change. So we better decide on what we finally want by M6.
Comment 1 Martin Oberhuber CLA 2008-02-15 09:49:45 EST 
Change committed:
[219098][api] FileServiceSubSystem should not be final