Bug 218959 - [Feature][New][Wizard]Feature wizard missing os/ws/arch on prepopulated plugin list
Summary: [Feature][New][Wizard]Feature wizard missing os/ws/arch on prepopulated plugi...
Status: CLOSED WONTFIX
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: bugday
Depends on:
Blocks:
 
Reported: 2008-02-14 10:29 EST by Andrew Niefer CLA
Modified: 2019-09-09 02:45 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Niefer CLA 2008-02-14 10:29:08 EST
When using the new Feature wizard to create a feature.xml, the second page lets you select plugins to prepopulate the feature with.

If a platform specific fragment is selected, the wizard should probably automatically set os/ws/arch values for that fragment.  If the os/ws/arch are not specified in the feature.xml, export can fail when a platform specific fragment does not resolve because it is for a different platform.
Comment 1 Chris Aniszczyk CLA 2008-02-14 10:40:13 EST
Oh ya, we have a feature wizard :)
Comment 2 Benjamin Cabé CLA 2008-02-14 10:54:33 EST
Bugday, you said bugday ? Mine ! :)

Should we add the same mechanism in the Feature editor ? ATM, when a fragment is added to a feature, OS/WS/NL/Arch values aren't automatically set...
Comment 3 Chris Aniszczyk CLA 2008-02-14 11:02:17 EST
Sure, it would be nice to be consistent.

I think Andrew would be pleased along with the other feature authors out there. We really didn't invest much time in the feature editor in 3.4 due to the unknowns surrounding p2.
Comment 4 Andrew Niefer CLA 2008-02-14 11:07:29 EST
This bug might be deceptively hard.  I realize now that this basically will require looking at the fragment's Eclipse-PlatformFilter (an LDAP filter) and trying to deduce ws/os/arch(/nl) from that.

Alternatively, look at FeatureGenerator.createFeature from pde.build, this is deducing ws/os/arch using a set of known configurations, a resolved state and help from BundleHelper.createFilter
Comment 5 Benjamin Cabé CLA 2008-02-14 11:14:18 EST
(In reply to comment #4)
> This bug might be deceptively hard.  I realize now that this basically will
> require looking at the fragment's Eclipse-PlatformFilter (an LDAP filter) and
> trying to deduce ws/os/arch(/nl) from that.

I've just noticed that too...!
I'll have a look at what has been done in PDE build, thanks for your tips :)
Comment 6 Andrew Niefer CLA 2008-02-14 17:25:08 EST
If os/ws/arch values can't be generated satisfactorily, one possibility would be warning for plugins that have a platform filter but no os/ws/arch. 
Comment 7 Benjamin Cabé CLA 2008-03-06 16:27:47 EST
i probably won't have time enough to look at this bug at the moment :-s
Comment 8 Chris Aniszczyk CLA 2008-03-06 16:44:14 EST
That's fine! Thanks for all your contributions!
Comment 9 Benjamin Cabé CLA 2008-03-07 12:29:12 EST
Well, after some reflexion, I think it's a bit difficult to implement a better solution than the alternative described by Andrew in comment #6 ...

Indeed, what one would expect if the plugin or fragment filter has been set to something like
(&(os=win32) (!(nl=fr)))
Should the feature declare an environment filter with all locales except the "fr" one? I would say the answer is no.
The same kind of problem occurs when the "|" operator is used, it's virtually impossible to generate the right os/ws/arch/nl values...

In fact, I'm afraid what I don't understand very well is why the "supported environment filter" has been split into 4 different fields and doesn't re-use the LDAP syntax...
Comment 10 Eclipse Webmaster CLA 2019-09-06 16:09:07 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
Comment 11 Julian Honnen CLA 2019-09-09 02:45:51 EDT
Please remove the stalebug flag, if this issue is still relevant and can be reproduced on the latest release.