Bug 218618 - x-friend and internal decorators incorrectly refreshed in the manifest editor
Summary: x-friend and internal decorators incorrectly refreshed in the manifest editor
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M6   Edit
Assignee: Benjamin Cabé CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-02-12 08:12 EST by Benjamin Cabé CLA
Modified: 2008-02-12 10:33 EST (History)
0 users

See Also:

Attachments
Proposed patch to fix some decorators bugs (4.29 KB, patch)
2008-02-12 08:20 EST, Benjamin Cabé CLA 		no flags Details | Diff
mylyn/context/zip (1.09 KB, application/octet-stream)
2008-02-12 08:20 EST, Benjamin Cabé CLA 		no flags Details
mylyn/context/zip (1.14 KB, application/octet-stream)
2008-02-12 08:34 EST, Benjamin Cabé CLA 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Cabé CLA 2008-02-12 08:12:25 EST 
Steps to reproduce:

0/ Create a bundle with some packages inside
1/ Export a package
  ---> no decorator in the Exported Packages section
2/ Make the package internal changing the radio button ("hidden from all...")
  ---> OK, we have the 'internal' decorator
3/ Add a bundle as friend
  --> KO, no refresh, the decorator is still "internal". But OK if you close and reopen the editor.
4/ Remove all friends (when there are ones) until the package becomes an 'internal' package again
  --> KO, the "friend" icon remains in the Exported Packages viewer.

4bis/ Add some friends, and then check "visible to downstream plugins", the package is still decorated as a "friend" one even if it now is a normal one. (in fact friends are kept in memory in case we check "hidden from all..." and the "friend" flag is not computed well.


... patch to come
Comment 1 Benjamin Cabé CLA 2008-02-12 08:20:38 EST 
Created attachment 89491 [details]
Proposed patch to fix some decorators bugs
Comment 2 Benjamin Cabé CLA 2008-02-12 08:20:43 EST 
Created attachment 89492 [details]
mylyn/context/zip
Comment 3 Benjamin Cabé CLA 2008-02-12 08:34:50 EST 
Created attachment 89494 [details]
mylyn/context/zip

cleaner context
Comment 4 Chris Aniszczyk CLA 2008-02-12 10:33:29 EST 
Looks good!
Comment 5 Chris Aniszczyk CLA 2008-02-12 10:33:48 EST 
Thanks again Ben!