Bug 218440 - [discovery] A service's properties should be shown in the 'Properties' view
Summary: [discovery] A service's properties should be shown in the 'Properties' view
Status: RESOLVED FIXED
Alias: None
Product: ECF
Classification: RT
Component: ecf.ui (show other bugs)
Version: 1.2.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: ecf.core-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-10 01:34 EST by Remy Suen CLA
Modified: 2008-03-04 07:35 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2008-02-10 01:34:50 EST
Seems like a logical choice for it to be in the 'Properties' view in my opinion.
Comment 1 Scott Lewis CLA 2008-02-10 12:09:40 EST
Not sure I agree that service properties belong in the properties view, as these properties are unlike many other properties displayed in properties view...and wouldn't this add a fair number of dependencies (?)...but I'm +1 if you want to go for it.
Comment 2 Scott Lewis CLA 2008-02-20 23:20:47 EST
I'll mess with this over next few days.
Comment 3 Scott Lewis CLA 2008-02-22 13:32:42 EST
Fix/enhancement released to HEAD.
Comment 4 Remy Suen CLA 2008-02-23 15:52:03 EST
I see that this has been implemented with tabbed properties. It certainly introduces more dependencies to the plug-in, I do not know the exact number. The idea I originally had in mind was to just have a separate plug-in that contributed an IPropertySource adapter to IServiceInfo.
Comment 5 Scott Lewis CLA 2008-02-23 17:01:39 EST
(In reply to comment #4)
> I see that this has been implemented with tabbed properties. It certainly
> introduces more dependencies to the plug-in, I do not know the exact number.
> The idea I originally had in mind was to just have a separate plug-in that
> contributed an IPropertySource adapter to IServiceInfo.
> 

Yes, it does add require bundle-level dependency on org.eclipse.ui.views.properties.tabbed.

I would be open to other impls.  Actually, I sort of hope/expect that all this can be replaced or enhanced by the discovery view work from lemmy.  I don't yet know what it's dependencies are, however.

I'm open to alternative implementations too.    
Comment 6 Markus Kuppe CLA 2008-03-04 07:35:32 EST
(In reply to comment #5)
> I would be open to other impls.  Actually, I sort of hope/expect that all this
> can be replaced or enhanced by the discovery view work from lemmy.  I don't yet
> know what it's dependencies are, however.

CQ 2038 (http://dev.eclipse.org/ipzilla/show_bug.cgi?id=2038) depends on EMF 2.3. 

org.eclipse.emf.ecore,
org.eclipse.emf.edit,
org.eclipse.emf.edit.ui

to be precise.