Bug 218173 - [local][files] filters without wildcard that resolve to no elements show element as directory
Summary: [local][files] filters without wildcard that resolve to no elements show elem...
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 3.0 M5   Edit
Assignee: David McKnight CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks: 174977
  Show dependency tree
 
Reported: 2008-02-07 09:51 EST by Radoslav Gerganov CLA
Modified: 2011-05-25 07:33 EDT (History)
0 users

See Also:

Attachments
Simple fix for this bug (1.39 KB, patch)
2008-02-07 09:54 EST, Radoslav Gerganov CLA 		mober.at+eclipse: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Radoslav Gerganov CLA 2008-02-07 09:51:07 EST 
1. Create new filter and specify "Subset by file name"
2. Enter non-existing file without using wildcards

The expected behaviour is to see an empty list for this filter but RSE shows the non-existing file as it is a directory.

This problem is caused by wrong condition in LocalFileService#convertToHostFiles(). I will propose a patch.
Comment 1 Radoslav Gerganov CLA 2008-02-07 09:54:00 EST 
Created attachment 89142 [details]
Simple fix for this bug
Comment 2 Martin Oberhuber CLA 2008-02-07 10:01:04 EST 
Thanks for the report - good catch. 
We've had other issues where non-existing nodes would be treated as directories. Assigning DaveM to assess the patch since he's got most insight in the issue.

Changed Summary - previous value was:
[local]non-generic filters don't work
Comment 3 David McKnight CLA 2008-02-07 11:13:22 EST 
Thanks very much for the patch!  I've applied it to cvs and committed it.
Comment 4 Martin Oberhuber CLA 2008-02-07 12:03:27 EST 
Radoslav - it's just a 3-liner, but could you still please post the legal message as per http://www.eclipse.org/dsdp/tm/development/committer_howto.php#external_contrib here on Bugzilla?
Comment 5 Radoslav Gerganov CLA 2008-02-07 12:44:30 EST 
I, Radoslav Gerganov, declare that I developed attached code from scratch, without referencing any 3rd party materials except material licensed under the EPL. I am authorized by my employer to make this contribution under the EPL.