Bug 218015 - [registry view] Plug-in Registry View filter refresh issues
Summary: [registry view] Plug-in Registry View filter refresh issues
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M6   Edit
Assignee: Jacek Pospychala CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-02-06 10:52 EST by Mark Melvin CLA
Modified: 2008-03-28 14:23 EDT (History)
3 users (show)

See Also:

Attachments
patch (2.88 KB, patch)
2008-02-07 11:24 EST, Jacek Pospychala CLA 		no flags Details | Diff
mylyn/context/zip (1.08 KB, application/octet-stream)
2008-02-12 20:20 EST, Chris Aniszczyk CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Melvin CLA 2008-02-06 10:52:32 EST 
Build ID: I20071213-1700

Steps To Reproduce:
1. Open the plug-in registry view
2. Type "ant" in the tree filter
3. Watch the results get filtered, but the text "Filter matched XXX of XXX plug-ins" does not change until you click the refresh button.


More information:
I have also noticed that it is quite easy to get this view in a state where the "Clear" button is never shown on the filter text area, so you always have to manually delete the filter text, then hit refresh manually again.  There is something wonky going on here on more than one level.
Comment 1 Jacek Pospychala CLA 2008-02-06 10:54:53 EST 
I can look into this.
Comment 2 Chris Aniszczyk CLA 2008-02-06 10:57:01 EST 
Cool!
Comment 3 Jacek Pospychala CLA 2008-02-07 05:43:12 EST 
Mark,
thanks for the report. I'd split this into actually two separate problems:

The first one - View description ("Filter matched...") does not update on filter change - we indeed don't update this text now.

The second one - "Clear" button doesn't appear every time it should - that's in fact the FilteredTree behavior. After filter text change, the viewer runs a Job to update tree structure with a certain time limit. For reason still unknown to me this update takes too much time, causes Job to be canceled and the button state is never updated.
It works correctly if there's not much items in view.
I see two approaches here: 
1. always update  "Clear" button state, not waiting for Job finish.
2. make tree update faster. (this might be needed anyway to correctly display "Filter matched..." text)
(I'll move it to a separate bug)
Comment 4 Jacek Pospychala CLA 2008-02-07 05:47:22 EST 
(In reply to comment #3)
> The second one - "Clear" button doesn't appear every time it should - [...]
> (I'll move it to a separate bug)

see bug 218150
Comment 5 Jacek Pospychala CLA 2008-02-07 11:24:54 EST 
Created attachment 89155 [details]
patch

Fix is to update view title, after filtering has been finished in FilteredTree.

Please review Chris.
Comment 6 Jacek Pospychala CLA 2008-02-12 15:13:32 EST 
(In reply to comment #5)
> Created an attachment (id=89155) [details]
> patch

ah my enigmatic comments ;)
the patch attached here fixes only this:
>The first one - View description ("Filter matched...") does not update on
>filter change - we indeed don't update this text now.

the solution for second issue:
>The second one - "Clear" button doesn't appear every time it should...
is worked on in bug 218150
Comment 7 Chris Aniszczyk CLA 2008-02-12 20:20:07 EST 
looks good.
Comment 8 Chris Aniszczyk CLA 2008-02-12 20:20:18 EST 
Created attachment 89581 [details]
mylyn/context/zip
Comment 9 Chris Aniszczyk CLA 2008-02-12 20:20:40 EST 
Thanks Jacek, I don't think there was a better way to do this than your solution :)
Comment 10 Jacek Pospychala CLA 2008-03-28 14:23:57 EDT 
Verified in I20080325-0100