Bug 218010 - [filters] Search view filter excludes checked items, whereas others include them
Summary: [filters] Search view filter excludes checked items, whereas others include them
Status: NEW
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: JDT-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-06 10:39 EST by Maxime Daniel CLA
Modified: 2008-02-07 05:38 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maxime Daniel CLA 2008-02-06 10:39:44 EST
3.4 M5

While the other views like Problems or Tasks use an explicit intermediate 'Show' menu and Search as no such intermediate menu, it took me a while to understand what was going on when I checked items in the Search pull down on its top right. In fact, I had to open the filters dialog before I realized that the checks meant 'exclude' in that case. I have noticed that we have other places in the interface where the exclude paradigm is used, notably for the outline view, but in that peculiar case, room for confusion is lessened by two factors:
- the icons are explicit enough (note that one of them is 'public only', whereas the others are crossed);
- there is not list of items in the first level menu; if the user wants to configure the filters, he uses the icons, or else drops into the filters dialog.

At the very least, an intermediate 'Hide' menu would make things more explicit, and would be more consistent with the other views. We may also want to adopt a more consistent behavior across all drop-down filters, and only do a 'Show' sub-menu.
Comment 1 Martin Aeschlimann CLA 2008-02-07 05:38:07 EST
Note that search has these entries in the section 'Filters...'.
That's consistent with the package explorer, call hierarchy, browsing views, navigator and the outline.

The problems view however has a section 'Show'.

I agree that this is subtle and is confusing at first.
We might think of changing all labels to 'Hide XY'. I think we should avoid adding an extra submenu. You want to quickly see what filters are active.