Community
Participate
Working Groups
In order to help setup the docbook documentation for the XSL Tooling, it would be helpful to have an xinclude Ant task. Xerces does support xinclude, but it has to be set as a java system property, which when you pass these to ant, Ant doesn't pass them on to the other properties. Lars Voegl has created an xinclude task for working around this problem. http://www.vogella.de/articles/DocBook/ar01s05.html Need to check with lars to see what license this is under, and see if he would be interested in contributing the code to the project.
Created attachment 88953 [details] Source Code
Hi, I would be honored if my code could be re-used within Eclipse. Please find attached the source code with the EPL license. Best regards, Lars
Targeting for 0.5M6. Lars, I may need to send the code through IP review. David, what is the process of code contributions? Do they only need to go through IP review if they are over 250 lines?
(In reply to comment #3) > Targeting for 0.5M6. > > Lars, I may need to send the code through IP review. David, what is the > process of code contributions? Do they only need to go through IP review if > they are over 250 lines? > Yes, only if over 250 lines. Otherwise, it's the responsibility of the committer to ensure contribution appears to have correct IP history, cleanliness, etc.
(In reply to comment #4) > (In reply to comment #3) > > Targeting for 0.5M6. > > > > Lars, I may need to send the code through IP review. David, what is the > > process of code contributions? Do they only need to go through IP review if > > they are over 250 lines? > > > > Yes, only if over 250 lines. Otherwise, it's the responsibility of the > committer to ensure contribution appears to have correct IP history, > cleanliness, etc. > Thanks. I'll get a CQ setup for it. Lars, Could you resubmit the contribution so that it is using the following packages: org.eclipse.wst.xsl.core.internal.xinclude And org.eclipse.wst.xsl.core.internal.ant Once I have the updated contribution, I'll get the CQ started so we can get it added to the package.
Created attachment 90972 [details] Updated Packages Source files with updated packages
(In reply to comment #6) > Created an attachment (id=90972) > Updated Packages > > Source files with updated packages Thanks, I submitted this for IP review. I don't expect any problems. Once it passes, I'll look at doing some enhancements to make the ANT task contributed to the other eclipse ant tasks, as well as get some unit tests to test the plugin out as well.
Just a note for myself: Use org.eclipse.ant.core.antTasks extension point to make the ant Task available to the built in eclipse support for running Ant. This also makes it available to head less builds as well.
Lars, IP review has the following questions, that need to be answered, all pretty basic. I don't think there is going to be any issue: 1. Confirm he wrote the code, 2. Confirm he has the rights to give the code to Eclipse, 3. Confirm that he is submitting the code for inclusion in future releases under the Eclipse Public License (I see that he has confirmed the EPL License) but will need confirmation of #1 and #2 for our records.
Hi, 1.) I confirm that I wrote the code 2.) I confirm that I have the rights to give the code to Eclipse Best regards, Lars
lars, the code is in parallel IP review right now, giving me the go ahead to add it to our CVS code. It looks good to make it into 0.5M6. Thanks for the contribution. I've added a noteworthy keyword to this bug so that I remember to mention this when we do 0.5M6 milestone.
This is implemented and will be available in 0.5M6. The XInclude ant task is added by extension point to the eclipse ant tasks, as xsl.xinclude. In order for this to work within eclipse, the ANT build must run with in the same build as eclipse. To use the included task outside of eclipse, the jar file that is include in the org.eclipse.wst.xsl.core/lib directory, will need to be added to the external class path. I'm leaving this open until I get final clearance from IP. Lars, thanks again for the contribution.
This code has passed IP review. Lars, it's checked in and will appear in the 0.5M6 milestone release. Thanks again for the contribution.
added contributed keyword for IP.
Mass Migration to wtp.inc.xsl
mass update to 3.1 target due to movement from wtp incubator to wtp source editing lost the original milestones.
