Description Maxime Daniel 2008-02-01 09:37:15 EST

3.4 M5

The following test case, which I suggest we add to OptionTests, fails on the second assertion:

public void test13_immutable_option() {
	Hashtable options = JavaCore.getDefaultOptions();
	String immutableValue = (String) options.get(JavaCore.CORE_ENCODING);
	assertEquals(ResourcesPlugin.getEncoding(), immutableValue); // ok
	options.put(JavaCore.CORE_ENCODING, immutableValue + "_extra_tail");
	JavaCore.setOptions(options);
	assertEquals(immutableValue, JavaCore.getOptions().get(JavaCore.CORE_ENCODING)); // ko
}

I cannot really relate the 'immutable' term in the javadoc to the observed behavior. I would suggest that the doc be explained further (what do we mean by immutable?) and that the behavior be fixed (while modifying the map in client code is unavoidable and OK anyway, JavaCore.getOptions().get(JavaCore.CORE_ENCODING) should always return the same value as ResourcesPlugin.getEncoding()).