Bug 217429 - [api] IllegalThreadStateException when multiple threads do AbstractHostShellOutputReader.addOutputListener()
Summary: [api] IllegalThreadStateException when multiple threads do AbstractHostShellO...
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 M5   Edit
Assignee: Martin Oberhuber CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2008-02-01 08:00 EST by Martin Oberhuber CLA
Modified: 2008-02-01 08:03 EST (History)
0 users

See Also:

Attachments
A patch fixing the issue (1.81 KB, patch)
2008-02-01 08:00 EST, Martin Oberhuber CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2008-02-01 08:00:15 EST 
From the dsdp-tm-dev mailing list:
  http://dev.eclipse.org/mhonarc/lists/dsdp-tm-dev/msg01630.html

Given a single IHostShell instance, multiple threads should be allowed to register as listeners on that shell. HostShellOutputReader should be made thread-safe in that respect.

-----------Enter bugs above this line-----------
TM 2.0
installation : eclipse-SDK-3.3 (I20070625-1500), cdt-4.0.0, emf-2.3.0
RSE install  : workspace HEAD
java.runtime : Sun 1.6.0_01-b06
os.name:     : Windows XP 5.1, Service Pack 1
------------------------------------------------
systemtype   : Windows-local, Dstore-win, Dstore-linux
targetos     : Red Hat Enterprise Linux WS release 4 (Nahant Update 3)
targetuname  : Linux parser 2.6.9-34.EL #1 i686 athlon i386 GNU/Linux
targetvm     : Sun Java HotSpot(TM) Client VM (build 1.4.2_12-b03, mixed mode)
------------------------------------------------
Comment 1 Martin Oberhuber CLA 2008-02-01 08:00:44 EST 
Created attachment 88544 [details]
A patch fixing the issue
Comment 2 Martin Oberhuber CLA 2008-02-01 08:03:41 EST 
Committing the patch since I cannot see any negative impact.

    protected final void AbstractHostShellOutputReader.startIfNotAlive() 

is new API.