Comment 1 Brian Bauman 2008-02-01 13:06:23 EST

What, 'esc' is too hard to hit :)

Isn't the launcher dialog modal?  What are you thoughts on what the link would do?

Comment 2 Michael Rennie 2008-02-01 13:12:29 EST

yes the launch dialog is modal.

I think the link should try to open the editor for the location in the UI thread so that deadlock occurs.

Comment 3 Chris Aniszczyk 2008-02-01 14:44:25 EST

Well, there are locations within the Eclipse and OSGi launch configurations that are a pain in the ass to get to. For example, if I wanted to jump to my workspace, I'd like to hyperlink the Location: and have it go to say '${workspace_loc}/../runtime-New_configuration' in windows explorer or whatever.

Or for my Configuration area because I want to find the damn platform.xml, have Location: go to '${workspace_loc}/.metadata/.plugins/org.eclipse.pde.core/Wassim like's virgin daiquiris in windows explorer or whatever.

Do you understand ?

Comment 4 Brian Bauman 2008-02-04 11:16:28 EST

> Do you understand ?

I get it now.  I wanted to make sure I understood what you were looking at hyperlinking to :) 

Comment 5 Benjamin Cabé 2008-02-08 04:46:31 EST

I'd be happy to post a patch for this bug.
I've got a local working copy. 
BTW, have you got any preference or idea for the UI ? At the moment it's something like a "show in explorer" push button next to the text field, but maybe we could imagine something a bit less intrusive, like pressing CTRL key to make the text field "clickable" ??

Comment 6 Chris Aniszczyk 2008-02-08 10:35:08 EST

I'd imagine a Link with a selection listener... something simple

For example, I'd want a similar pattern to what we have within the Product editor in the Configuration File section where 'File:' is hyperlinked to take you to the file.

Comment 7 Chris Aniszczyk 2008-02-08 10:35:21 EST

Thanks for looking into this one Ben :)

Comment 8 Benjamin Cabé 2008-02-09 11:35:35 EST

Created attachment 89338 [details]
mylyn/context/zip

Comment 9 Benjamin Cabé 2008-02-09 11:36:26 EST

Created attachment 89339 [details]
org.eclipse.pde.ui.patch

Comment 10 Benjamin Cabé 2008-02-09 11:40:21 EST

Created attachment 89340 [details]
screenshot

Comment 11 Benjamin Cabé 2008-02-09 11:45:10 EST

The patch uses SWT.Program to launch the default Program associated to the location (file explorer -tested on Win XP, Ubuntu & MacOSX- when it's a folder, default editor when it's a file). 

Comment 12 Chris Aniszczyk 2008-02-11 10:33:32 EST

Thanks, will look at it today.

Comment 13 Chris Aniszczyk 2008-02-11 10:53:50 EST

nice patch! This is everything I dreamed for and more. I can now quickly jump to the workspace area >:)

Comment 14 Benjamin Cabé 2008-02-11 10:58:13 EST

great :)