Bug 217277 - [logview] view needs description text
Summary: [logview] view needs description text
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.4 M5   Edit
Assignee: Jacek Pospychala CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on: 73151
Blocks:
  Show dependency tree
 
Reported: 2008-01-31 10:56 EST by Chris Aniszczyk CLA
Modified: 2008-02-05 15:03 EST (History)
2 users (show)

See Also:


Attachments
patch (5.89 KB, patch)
2008-02-01 03:55 EST, Jacek Pospychala CLA
no flags Details | Diff
mylyn/context/zip (1.95 KB, application/octet-stream)
2008-02-01 10:39 EST, Chris Aniszczyk CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Aniszczyk CLA 2008-01-31 10:56:03 EST
Simliar to how the console view has description text on which VM and launch configuration you do, we should do something for the log you're currently look at.

I envision something like "[workspace log]"

or

"[launch configuration name] c:/locaationblahbalbha"

Feel free to be creative :)
Comment 1 Jacek Pospychala CLA 2008-02-01 03:55:10 EST
Created attachment 88518 [details]
patch

it actually sets title as:

Workspace log file    - for current workspace log file
Launch Configuration [C:\long\long\Launch Configuration\workspace\.metadata\.log]
C:\long\long\Launch Configuration\workspace\.metadata\.log - if log does not belong to any launch configuration


the other way ("[Name] Path") didn't look good to me.
You may play with it modifying messages.properties :)
Comment 2 Chris Aniszczyk CLA 2008-02-01 09:53:26 EST
yay!
Comment 3 Chris Aniszczyk CLA 2008-02-01 10:39:26 EST
thanks Jacek, I had to fix an issue with paths not being relativized, but other than that the patch was perfect!

A thought hit me that in the future, we may consider an extension point for the logview instead of the current LogFilesManager approach... however, that's a low priority and until someone asks for it, let's not worry about it :)
Comment 4 Chris Aniszczyk CLA 2008-02-01 10:39:30 EST
Created attachment 88564 [details]
mylyn/context/zip
Comment 5 Jacek Pospychala CLA 2008-02-01 10:47:58 EST
(In reply to comment #3)
> A thought hit me that in the future, we may consider an extension point for the
> logview instead of the current LogFilesManager approach... however, that's a
> low priority and until someone asks for it, let's not worry about it :)

gosh! that'd be my first extension point in Eclipse... not sure if I could handle this! :P

imagine different log providers for different launch configs (Java Apps, Web servers, ...)! Automatic log formats detection, hundrets of log patterns (Apache logs, log4j, ...) :)
TPTP Logging people would kill us.

Comment 6 Brian Bauman CLA 2008-02-05 15:03:35 EST
Verified on I20080204-0800