Bug 217126 - [performance] Too many performance tests have only one measure
Summary: [performance] Too many performance tests have only one measure
Status: CLOSED WONTFIX
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Markus Keller CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: performance, test
Depends on: 89804
Blocks:
  Show dependency tree
 
Reported: 2008-01-30 12:30 EST by Frederic Fusier CLA
Modified: 2020-01-26 11:53 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Frederic Fusier CLA 2008-01-30 12:30:37 EST
Looking at the Scenario Status Table of the JDT/UI component performance tests, it  appears that most of the tests have only one run (eg. standard error = '[n/a]').

This has a strong impact on the tests reliability and make the verification hard to be accurate. The global result is that no regression was noticed on this component although the fingerprints looks not so good; a large number of tests in the fingerprints are red or yellow.

IMO, this may give to users a negative feeling about the global performance of this component although there's no real performance issue...
Comment 1 Markus Keller CLA 2009-04-06 12:09:38 EDT
All these tests fall under 2 categories:
- cold tests, i.e. tests to verify that we're not unacceptably slow the *first* time we perform an operation
- very short tests for high-level operations like refactorings, which would need a big number of repetitions (often > 100) to become reliable

For both of these categories, our main interest is to ensure that the scenarios stay in a reasonable absolute range. A 20% difference in the 100ms region is not a problem for the user in these scenarios. I believe that the jitter is mostly due to unpredictable disk I/O.

Best would be if we could just change these tests to only assert that we stayed in a given bound (disregarding small absolute jumps in execution time). This is bug 89804.
Comment 2 Dani Megert CLA 2009-04-07 02:41:10 EDT
I suggest we change the tests to assert absolute values and revive bug 89804. Frédéric, can you take a look at this?
Comment 3 Markus Keller CLA 2009-04-16 04:42:33 EDT
I've removed the OrganizeImportsPerfTest#testOrganizeImport() from the summary for now, since it usually takes less than 100ms and is thus not accurately measurable.

We don't plan to do anything else here, unless the issues in bug 89804 get addressed (which could also be done in 3.6, IMO).
Comment 4 Eclipse Genie CLA 2020-01-26 11:53:11 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.