217022 – PDELabelProvider should handle system.bundle better

Bug 217022 - PDELabelProvider should handle system.bundle better

Summary: PDELabelProvider should handle system.bundle better

Status:	RESOLVED FIXED

Alias:	None

Product:	PDE
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	3.4
Hardware:	PC Windows XP

Importance:	P3 enhancement (vote)
Target Milestone:	3.4 M6
Assignee:	Benjamin Cabé
QA Contact:

URL:
Whiteboard:
Keywords:	contributed

Depends on:
Blocks:

Reported:	2008-01-29 20:20 EST by Chris Aniszczyk
Modified:	2008-02-21 09:55 EST (History)
CC List:	3 users (show)

See Also:

Attachments
Proposed patch (4.56 KB, patch) 2008-02-19 18:08 EST, Benjamin Cabé	no flags	Details \| Diff
mylyn/context/zip (1.01 KB, application/octet-stream) 2008-02-19 18:08 EST, Benjamin Cabé	no flags	Details
system.bundle icon (327 bytes, image/gif) 2008-02-19 18:09 EST, Benjamin Cabé	no flags	Details
system.bundle "required" icon (348 bytes, image/gif) 2008-02-19 18:09 EST, Benjamin Cabé	no flags	Details
... forgot to add NON-NLS tags.... (4.77 KB, patch) 2008-02-19 18:29 EST, Benjamin Cabé	no flags	Details \| Diff
org.eclipse.pde.ui.patch (2.11 KB, patch) 2008-02-21 09:55 EST, Chris Aniszczyk	no flags	Details \| Diff
mylyn/context/zip (2.08 KB, application/octet-stream) 2008-02-21 09:55 EST, Chris Aniszczyk	no flags	Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Chris Aniszczyk

2008-01-29 20:20:05 EST

For example, if you go to add a plug-in and type system.bundle, you have no idea what system bundle is currently available. It would be nice to adorn the label provider with something like...

system.bundle [org.eclipse.osgi (xxxx)]

This would provide a hint at least to developers to what system bundle is being used.

Comment 1 Chris Aniszczyk

2008-01-29 20:20:29 EST

Brian, thoughts?

Comment 2 Thomas Watson

2008-01-30 08:55:28 EST

I'm not sure how necessary this is.  If you are using system.bundle as the alias to the Framework then you do not really care what the underlying framework is.  If you have a requirement for a specific framework then you would use the Framework specific symbolic name, not system.bundle.

I'm not saying it wouldn't be nice to see something like this.  But I think it is a nice to have and not a hard requirement.

Comment 3 Chris Aniszczyk

2008-01-30 09:15:48 EST

It's definitely a nice to have.

Comment 4 Brian Bauman

2008-01-30 10:22:23 EST

I like the idea.  Do you think we should try to come up with a slightly different color icon similar to the plugin icon so people would realize it is a special bundle?

Comment 5 Benjamin Cabé

2008-02-19 18:08:17 EST

Created attachment 90119 [details]
Proposed patch

It would be great if "system.bundle" could be defined somewhere as a constant :)

Comment 6 Benjamin Cabé

2008-02-19 18:08:20 EST

Created attachment 90120 [details]
mylyn/context/zip

Comment 7 Benjamin Cabé

2008-02-19 18:09:10 EST

Created attachment 90121 [details]
system.bundle icon

Comment 8 Benjamin Cabé

2008-02-19 18:09:50 EST

Created attachment 90122 [details]
system.bundle "required" icon

Comment 9 Benjamin Cabé

2008-02-19 18:12:33 EST

I just played around with hue/saturation to have a slightly different icon

Comment 10 Benjamin Cabé

2008-02-19 18:29:24 EST

Created attachment 90124 [details]
... forgot to add NON-NLS tags....

Comment 11 Chris Aniszczyk

2008-02-20 09:24:51 EST

Thanks Benny, will try to look at this ASAP.

Comment 12 Chris Aniszczyk

2008-02-21 09:55:05 EST

Created attachment 90354 [details]
org.eclipse.pde.ui.patch

I made some stylistic changes and just simplified what we showed to make it cleaner.

Thanks for the patch and inspiration Ben!

Comment 13 Chris Aniszczyk

2008-02-21 09:55:09 EST

Created attachment 90355 [details]
mylyn/context/zip

Comment 14 Chris Aniszczyk

2008-02-21 09:55:33 EST

fixed