Bug 216944 - [Discovery][SLP][JmDNS] SLP RFC2608 and JmDNS doesn't fully support URL
Summary: [Discovery][SLP][JmDNS] SLP RFC2608 and JmDNS doesn't fully support URL
Status: ASSIGNED
Alias: None
Product: ECF
Classification: RT
Component: ecf.providers (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 2.1.0   Edit
Assignee: Markus Kuppe CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 258252
Blocks:
  Show dependency tree
 
Reported: 2008-01-29 13:33 EST by Markus Kuppe CLA
Modified: 2009-03-10 12:10 EDT (History)
2 users (show)

See Also:

Attachments
mylyn/context/zip (1.15 KB, application/octet-stream)
2008-02-08 06:04 EST, Markus Kuppe CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Kuppe CLA 2008-01-29 13:33:31 EST 
Hi,

jSLP RC2 doesn't support the user-info part [user-info@]host[:port] in URIs. Additionally support for scheme [scheme:][//authority][path][?query][#fragment] isn't entirely covered by the SLP RFC #2608 either.
Although Jan is open to adding user-info support in jSLP, it won't do us any good for Ganymede because of the CQ deadline.

Alternatively we might want to consider carrying scheme and user-info as ServiceProperties identified by ECF specific keys. Thoughts?

Btw I discovered this problem while investigating failing jSLP provider test cases in the ECF discovery test suite. Maybe we should talk about the rational behind those tests as Jan suggested, the user-info use case is rather questionable.

Cheers
Markus
Comment 1 Markus Kuppe CLA 2008-01-29 13:33:48 EST 
Adding Jan
Comment 2 Markus Kuppe CLA 2008-02-08 06:04:53 EST 
Apparently jSLP and OpenSLP are robust to adding the user-info into the ServiceURL, though I'll leave this bug open for the moment.
Comment 3 Markus Kuppe CLA 2008-02-08 06:04:57 EST 
Created attachment 89239 [details]
mylyn/context/zip
Comment 4 Scott Lewis CLA 2008-05-23 16:15:57 EDT 
changing target milestone
Comment 5 Markus Kuppe CLA 2008-05-30 08:13:01 EDT 
Essentially this is an issue with RFC2608 being imprecise if the second part of a ServiceURL can be seen as an URI. However at least jSLP and OpenSLP are robust, though jSLP doesn't let you register ServiceURLs containing a [user-info]  composed out of username _and_ password. Nor does it support [query] or [fragments].

The only viable options for 2.0 are:
1) Transfer password in the generic ServiceProperties. This has obviously the downside that all SAs have to be set up and store the pass in the property.
2) Use jSLP 1.0.0.RC4 (not out yet) which had to be improved first to handle this case for ECF 2.0. This might not be possible because of the IP process and given time frame/resources.
The changes in ECF discovery however are minor.

Moving this one to 2.1 as long as we don't have a fix in jSLP and can be sure a possible CQ for jSLP1.0.0.RC4 will be approved by Ganymede.

Btw. the path component of an URI is supported as per
https://bugs.eclipse.org/bugs/show_bug.cgi?id=234803
Comment 6 Markus Kuppe CLA 2009-03-10 12:10:53 EDT 
Same is true for JmDNS. Thus commenting the user part in org.eclipse.ecf.tests.discovery.DiscoveryTestHelper.createDefaultURI() for the moment.