Community
Participate
Working Groups
In 3.4, PDE Build will have support to generate p2 metadata when building/exporting plugins, features, and update sites. If Eclipse is p2 aware, metadata generation should be invoked. To do so, we must pass a number of properties to PDE Build. generate.p2.metadata = true p2.metadata.repo = file://${buildDirectory}/repo p2.artifact.repo = file://${buildDirectory}/repo p2.flavor = tooling p2.publish.artifacts = false Additional info about PDE/p2 integration can be found on the wiki page at http://wiki.eclipse.org/Equinox_p2_PDE_Integration
This should be pretty simple. Do you want to take a crack at it Curtis? BTW, my favorite property from above is "p2.flavor", can we put spicy? :)
I assumed that it would be Darin or myself that would be working on this. We also will be working on the p2 target provisioner. Hopefully spicy and honey garlic flavours will be supported.
Created attachment 88629 [details] Work in progress
Created attachment 88845 [details] Patch for M5 This patch adds the needed properties on export to generate p2 metadata. However, they are only available when exporting to a directory. For M6 we will need to handle exporting to an archive file, add constants for the properties, and possibly add the option to turn off the generation via a preference.
Chris, it would be nice if metadata generation could be done, even in a limited context in M5. If possible, please review and commit the patch. The additional properties have no effect in non-p2 builds.
looks ok, doesn't break exisiting scenarios atm :)
Created attachment 88851 [details] mylyn/context/zip
Thanks Curtis for submitting a patch in time to include it in M5 and thanks Chris for making sure it got in. You guys rock!
There are a couple of issues: 1) Exporting for multiple platforms, the resulting p2 data is incorrect because of the platform subfolders in the export directory 2) Exporting Products. The product metadata is not complete because export does not run the top level assemble script, it only runs the platform specific assemble scripts. 3) I am informed that our flavor should be "tooling" for now 4) There is probably a problem with folder shaped features/plugins Attached patch does 1) set p2.publish.artifacts = true 2) set p2.*.repo = destination/p2repo 3) set flavor=tooling 4) Turn of p2 metadata generation for product export The result is for export you get the normal results + a p2repo folder. The p2repo folder contains copies of all the jars and the metadata in the correct shape.
Created attachment 88941 [details] updated patch
Thank you for the patch and the clarification Andrew. Brian/Chris, can you guys put this patch in for M5?
I can review this one.
Looks safe to me. Thanks Andrew for the help, we always appreciate the guidance. Patch committed to HEAD, will be available in the next I-Build.
