Bug 216291 - [1.5][compiler] Compiler messages should use "1.5" instead of "5.0"
Summary: [1.5][compiler] Compiler messages should use "1.5" instead of "5.0"
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M5   Edit
Assignee: Maxime Daniel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-23 10:38 EST by Jerome Lanneluc CLA
Modified: 2008-02-04 07:11 EST (History)
3 users (show)

See Also:

Attachments
Patch provided by Daniel Megert (2.58 KB, patch)
2008-01-23 10:39 EST, Jerome Lanneluc CLA 		no flags Details | Diff
Dani's patch (unchanged), plus tests. (104.04 KB, patch)
2008-01-31 04:42 EST, Maxime Daniel CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jerome Lanneluc CLA 2008-01-23 10:38:25 EST 
I20080122-1600

From a discussion in the JDT call, it appears that "5.0" should be used to talk about J2SE only. At the compiler level, "1.5" should be used. Compiler messages need to be changed.
Comment 1 Jerome Lanneluc CLA 2008-01-23 10:39:43 EST 
Created attachment 87657 [details]
Patch provided by Daniel Megert

Compiler tests will need to be changed accordingly.
Comment 2 Philipe Mulet CLA 2008-01-23 13:15:02 EST 
Are there no occurrence of 6.0 either ?
Comment 3 Jerome Lanneluc CLA 2008-01-23 13:22:42 EST 
Surprisingly no compiler tests failed after applying this patch. Maxime can you please add the corresponding tests and release Dani's patch at the same time ?
Comment 4 Maxime Daniel CLA 2008-01-24 02:36:00 EST 
I'll do.

I'll also double-check whether we have 6.0 (and 7.0) literals or not.

BTW, would not this imply that the batch compiler command line be aligned? While simply getting rid of 5.0 (and 6.0 and 7.0) as a possible level value in options might be too harsh, we could deprecate it and remove it from the options documentation. Or we could else leave this unchanged, the rationale being that 5, 5.0, 6, 6.0, 7, 7.0 are input convenience aliases that imply no strong relationship to the language level official denomination. (The use of 5, 6 and 7 clearly belong to a 'let's use non-standard but intuitive values' approach.)
I would personally vote for keeping the batch options unchanged, but if anyone feels this is wrong, pls open a separate bug.
Comment 5 Dani Megert CLA 2008-01-24 03:20:36 EST 
>BTW, would not this imply that the batch compiler command line be aligned?
>While simply getting rid of 5.0 (and 6.0 and 7.0) as a possible level value in
>options might be too harsh, we could deprecate 
No, they should stay as is because they are officially allowed/available as alias.
Comment 6 Dani Megert CLA 2008-01-24 03:21:03 EST 
>Surprisingly no compiler tests failed after applying this patch.
Lucky me ;-)
Comment 7 Dani Megert CLA 2008-01-30 03:58:43 EST 
Can you commit the patch for M5 so that the JDT Core messages are consistent with the other places in the UI side? Thanks.
Comment 8 Philipe Mulet CLA 2008-01-30 04:33:38 EST 
Yes, M5 is the target (my mistake).
Comment 9 Maxime Daniel CLA 2008-01-31 04:42:02 EST 
Created attachment 88387 [details]
Dani's patch (unchanged), plus tests.
Comment 10 Maxime Daniel CLA 2008-01-31 04:44:04 EST 
Released for 3.4M5.
Comment 11 Maxime Daniel CLA 2008-01-31 04:45:19 EST 
Notes: I checked that I could not find any unexplained 5.0, 50, 6.0 or 60 string in the sources. I also hunted copyrights and aligned them.
Comment 12 Eric Jodet CLA 2008-02-04 07:11:28 EST 
Verified for 3.4M5 using build I20080204-0010