Bug 215848 - [Doc] Context help editor needs context help of its own
Summary: [Doc] Context help editor needs context help of its own
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M6   Edit
Assignee: Blazej Kroll CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, contributed, greatbug
Depends on: 215091
Blocks:
  Show dependency tree
 
Reported: 2008-01-18 14:37 EST by Curtis Windatt CLA
Modified: 2008-03-06 14:48 EST (History)
2 users (show)

See Also:


Attachments
patch adding context help editor's context help (6.80 KB, patch)
2008-02-29 13:39 EST, Blazej Kroll CLA
no flags Details | Diff
images used within help page (453.61 KB, application/x-zip-compressed)
2008-02-29 13:40 EST, Blazej Kroll CLA
no flags Details
Associates context help id with UI (2.57 KB, patch)
2008-02-29 14:51 EST, Curtis Windatt CLA
no flags Details | Diff
Small changes (11.67 KB, patch)
2008-03-06 07:00 EST, Blazej Kroll CLA
no flags Details | Diff
Updated patch (9.99 KB, patch)
2008-03-06 11:46 EST, Curtis Windatt CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Curtis Windatt CLA 2008-01-18 14:37:25 EST
The new editor needs help.
Comment 1 Curtis Windatt CLA 2008-01-18 14:38:11 EST
Marking as bugday.  This will have to be done sometime in 3.4.
Comment 2 Curtis Windatt CLA 2008-01-23 14:18:19 EST
The new context help wizard will need help as well.  See Bug 216019.
Comment 3 Blazej Kroll CLA 2008-02-13 08:56:24 EST
I'd like to prepare a patch for this bug, for the nearest bugday. 
Comment 4 Curtis Windatt CLA 2008-02-13 09:30:59 EST
I say go for it.  Let me know if you need any more info on how the editor works.
Comment 5 Chris Aniszczyk CLA 2008-02-13 10:44:48 EST
Are you familiar with how to add context help Blazej?
Comment 6 Blazej Kroll CLA 2008-02-19 05:44:35 EST
Well, not quite. It's one of first serious assignment dealing with adding context help.. however, I'll do my best :-)
Comment 7 Blazej Kroll CLA 2008-02-29 13:39:20 EST
Created attachment 91221 [details]
patch adding context help editor's context help

I created a context help editor's context help page. Can you review it and give me remarks? Also attaching images, which are used by the help .htm page.
Comment 8 Blazej Kroll CLA 2008-02-29 13:40:33 EST
Created attachment 91222 [details]
images used within help page

images used within help page
Comment 9 Curtis Windatt CLA 2008-02-29 14:49:34 EST
Great work so far Blazej!  

Here are the things that still need to be fixed

1) Please replace the context help xml entry with the following (more consistent wording and changed 'content' to 'context'.
<context id="ctx_help_editor" title="Context Help Editor">
    	<description>This editor creates a context help XML file, which allows you to create and edit dynamic help entries.</description>
    	<topic href="guide/tools/editors/ctx_help_editor/editor.htm" label="Context Help Editor"/>
</context>

2) The context has to be specified by the editor in code, I will attach a patch for this.

3) The editor page should use bolding for proper names of editors, pages and actions.  Titles should be done as headings.  Take a look at the Extension Point Schema Editor page (org.eclipse.pde.doc.user/guide/tools/editors/schema_editor/editor.htm) as an example.

4) It would be cool if we mentioned the extension to add to register the context help xml file.  This isn't as important right now as in the future we will add an action that registers it for you similar to the ToC Editor.

5) The ToC entry points to the same page twice.  I assume you meant to use the page html that is in the patch but is not used anywhere. 
Comment 10 Curtis Windatt CLA 2008-02-29 14:51:58 EST
Created attachment 91229 [details]
Associates context help id with UI
Comment 11 Blazej Kroll CLA 2008-03-06 07:00:46 EST
Created attachment 91748 [details]
Small changes

Changes made by instructions given.
Comment 12 Blazej Kroll CLA 2008-03-06 07:04:29 EST
Curtis, I've attached a patch which changes the files as you requested. As for the ToC entry point that I've linked - I deleted the link, however it was placed because I created a patch to a releated bug 198841. Waiting for your feedback.
Comment 13 Curtis Windatt CLA 2008-03-06 11:46:39 EST
Created attachment 91774 [details]
Updated patch

This patch fixes some things in the previous patch.

1) Fixed minor things that look bad when people find them in the SDK later, like spelling mistakes and incorrect capitalization.  Removed the TODO to add the help.

2) Added <strong> tags to emphasize command/section titles, replacing the <p class="style2"> which just puts it on a new line.

3) Added <p> tags around the paragraphs so spaces show up in the right spot.
Comment 14 Curtis Windatt CLA 2008-03-06 11:49:58 EST
Great work Blazej!  With my minor changes the doc is ready to be committed.  I'm sure Chris will do the honours.  If you are interested in doing other help doc for PDE (or any other kind of bug) we would love it.

Chris, when getting the images, one of them context_details.png is not used anywhere, so it doesn't need to be committed.
Comment 15 Chris Aniszczyk CLA 2008-03-06 14:41:28 EST
Thanks guys!!

This is a great bug. It goes to show that you don't have to just contribute code, documentation is valuable too. Thank you very much Blazej!
Comment 16 Chris Aniszczyk CLA 2008-03-06 14:48:38 EST
Thanks guys! Awesome stuff! I opened another bug for your picture Blazej to put on the PDE hall of fame :)

> 20080306