Bug 215759 - DOM AST regression tests should be improved
Summary: DOM AST regression tests should be improved
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: 3.4 M5   Edit
Assignee: David Audel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-18 04:06 EST by David Audel CLA
Modified: 2008-02-05 07:02 EST (History)
0 users

See Also:

Attachments
Proposed fix (137.10 KB, patch)
2008-01-21 04:24 EST, David Audel CLA 		no flags Details | Diff
Patch for component.xml (787 bytes, patch)
2008-01-21 05:00 EST, David Audel CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Audel CLA 2008-01-18 04:06:13 EST 
Currently DOM AST are difficult to read, write and maintain.
They should have only one assert method call per test and they should be easy to read.
Comment 1 David Audel CLA 2008-01-21 04:24:19 EST 
Created attachment 87379 [details]
Proposed fix

This patch improve tests and move NaiveASTFlattener in an internal package.
Comment 2 David Audel CLA 2008-01-21 04:34:20 EST 
Released for 3.4M5

Tests added
  ASTConverterBugsTest#testBug215759a() -> testBug215759b()

Now NaiveASTFlattener is in org.eclipse.jdt.internal.core.dom
Comment 3 David Audel CLA 2008-01-21 05:00:22 EST 
Created attachment 87382 [details]
Patch for component.xml

NaiveASTFlattener must be removed from component.xml
Comment 4 David Audel CLA 2008-01-21 05:02:38 EST 
Released the second patch.
Comment 5 Frederic Fusier CLA 2008-02-05 07:02:34 EST 
Verified for 3.4M5 looking at tests code.