Bug 215743 - [schema] errors should be displayed in problems and package explorer views
Summary: [schema] errors should be displayed in problems and package explorer views
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 M1   Edit
Assignee: Benjamin Cabé CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday
Depends on:
Blocks: 284925
  Show dependency tree
 
Reported: 2008-01-17 23:03 EST by Simon Archer CLA
Modified: 2009-07-28 15:48 EDT (History)
4 users (show)

See Also:

Attachments
Screen shots (104.73 KB, image/png)
2008-01-17 23:05 EST, Simon Archer CLA 		no flags Details
test schema definition (6.14 KB, application/octet-stream)
2008-01-17 23:53 EST, Brian Bauman CLA 		no flags Details
Patch for SchemaErrorReporter.java (7.21 KB, patch)
2009-07-28 14:06 EDT, Simon Muschel CLA 		contact: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Archer CLA 2008-01-17 23:03:55 EST 
When working with an exsd file, an error is only shown within the Extension Point Schema editor, whereas it should also result in an entry in the Problems view and decorators (on the file, parent folder(s), project and working set(s)) in the Package Explorer view.

Only showing the problem in the editor means that you only see the error when the editor is open and you're paying particular attention to the editor's details.
Comment 1 Simon Archer CLA 2008-01-17 23:05:01 EST 
Created attachment 87223 [details]
Screen shots
Comment 2 Brian Bauman CLA 2008-01-17 23:52:26 EST 
Sounds logical.

Attaching a schema to test with.  I modified PDE schema to provide an unresolved "included schema" and an unresolved element in a sequence which should provide similar results as to what Simon is experiencing.
Comment 3 Brian Bauman CLA 2008-01-17 23:53:13 EST 
Created attachment 87224 [details]
test schema definition

example schema definition
Comment 4 Simon Muschel CLA 2009-07-28 14:06:04 EDT 
Created attachment 142797 [details]
Patch for SchemaErrorReporter.java

I've added additional validation steps to SchemaErrorReporter.
It now validates if included schemas are valid and also if referenced elements are defined. Errors are reported in problems view and package explorer.
Comment 5 Benjamin Cabé CLA 2009-07-28 14:10:28 EDT 
Thanks Simon!
Comment 6 Chris Aniszczyk CLA 2009-07-28 14:54:47 EDT 
If this is good, we can commit this towards M1.
Comment 7 Benjamin Cabé CLA 2009-07-28 15:48:04 EDT 
Thanks for this simple and elegant patch Simon :-)
I've released it with minor wording changes for the error messages.

It is available in HEAD > 20090728.

Since we now handle included schemas, I've opened bug 215743 in order to improve the schema compiler to trigger recompilation of every depending schema(s) on a schema modification...