Bug 215553 - Sometimes launching debug session locks up UI forever
Summary: Sometimes launching debug session locks up UI forever
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug (show other bugs)
Version: 4.0.2   Edit
Hardware: PC Windows XP
: P3 critical (vote)
Target Milestone: 4.0.3   Edit
Assignee: Doug Schaefer CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-01-16 14:57 EST by Elena Laskavaia CLA
Modified: 2008-06-22 02:37 EDT (History)
1 user (show)

See Also:

Attachments
Patch 4_0 (9.39 KB, patch)
2008-01-16 15:01 EST, Elena Laskavaia CLA 		bjorn.freeman-benson: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elena Laskavaia CLA 2008-01-16 14:57:41 EST 
Scenario:
 Launch debug session
 UI does not respond anymore
 Alternatively UI works but debug session does not react to any user commands

Reason:
 CDI/MI uses unsafe locks (Target::Lock) and does not properly handles lock aquire/release. I.e. release not always in finally block, and when it is, 
there is something else that can through an exception before release is hit.
 So after exception and unreleased lock UI thread calls something that require Target lock - it is never going to come back

I went throw all acquire/release for Target and fixed finally blocks, patch is attached.
Comment 1 Elena Laskavaia CLA 2008-01-16 15:01:39 EST 
Created attachment 87093 [details]
Patch 4_0

Patch for 4.0. Sorry it has some leftovers from Bug 215416.
Comment 2 Doug Schaefer CLA 2008-01-28 14:57:14 EST 
Patch applied to 4.0 and HEAD. Thanks Alena!
Comment 3 Doug Schaefer CLA 2008-06-03 15:08:37 EDT 
assigning
Comment 4 Doug Schaefer CLA 2008-06-03 15:09:00 EDT 
done